fix: input validation gap in rsconnect add (#758)

* add early check

* bandaid test

Author: joshyam-k

rsconnect/main.py

@@ -741,6 +741,12 @@ def add(
     set_verbosity(verbose)
     output_params(ctx, locals().items())
 
+    if not server and not any([token, secret, account]):
+        raise RSConnectException(
+            "`rsconnect add` requires -s/--server (for Posit Connect) or -A/--account, -T/--token, "
+            "and -S/--secret (for shinyapps.io)."
+        )
+
     validation.validate_connection_options(
         ctx=ctx,
         url=server,

tests/test_main.py

@@ -715,6 +715,28 @@ def test_add_shinyapps(self):
             if original_server_value:
                 os.environ["CONNECT_SERVER"] = original_server_value
 
+    def test_add_name_only_missing_server_and_credentials(self):
+        """Regression test: `rsconnect add -n x` should produce a validation error, not a TypeError."""
+        original_api_key_value = os.environ.pop("CONNECT_API_KEY", None)
+        original_server_value = os.environ.pop("CONNECT_SERVER", None)
+        try:
+            runner = CliRunner()
+            result = runner.invoke(
+                cli,
+                [
+                    "add",
+                    "--name",
+                    "some-name",
+                ],
+            )
+            assert result.exit_code == 1, result.output
+            assert "`rsconnect add` requires" in str(result.exception)
+        finally:
+            if original_api_key_value:
+                os.environ["CONNECT_API_KEY"] = original_api_key_value
+            if original_server_value:
+                os.environ["CONNECT_SERVER"] = original_server_value
+
     def test_add_shinyapps_missing_options(self):
         original_api_key_value = os.environ.pop("CONNECT_API_KEY", None)
         original_server_value = os.environ.pop("CONNECT_SERVER", None)

vetiver-testing/vetiver-requirements.txt

@@ -1,6 +1,6 @@
 pandas
 numpy
-pydantic
+pydantic<2
 pytest
 pins
 vetiver