Skip to content

Test Quality #100

@pmaasz

Description

@pmaasz
  • Most tests are smoke tests: result.success == True, len(result) > 0, isinstance(x, dict). They catch crashes but not regressions in physics.
  • No seeded RNG in stochastic tests. Any test that exercises SA / GA / MC is inherently flaky — it either uses a huge tolerance or asserts nothing specific.
  • No convergence assertion on optimizers — i.e. no test says "merit after ≤ 0.5 × merit before". Adding even one such test per algorithm would be high value.
  • Numerical tolerances are often hand‑picked rather than derived (places=4 in test_aberrations.py:60).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions