Dont open connections if its not used

[PurHur]

Currently the imap connection in established when the extension is loaded. That is not good.

Please conenct only if its used and then also check if a reconnect is needed.

[issue-label-bot]

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.60. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[pmaasz]

When executing your tests you authenticate yourself towards the mail server with the given credentials (behat.yaml). In the case that those credentials are incorrect or the server refuses the connection for whatever reason the tests fail.

To solve this behaviour, I would implement a Singleton and a Server class that handles the connection so it will fail when the appropriate test is executed. Also I should implement an exception handling so that the following tests will still be executable and behat won't crash. A solution would be to refactor the extension as a proper extension instead of a FeatureContext trait.

Thank you for your report!

Regards
pmaasz

[pmaasz]

The first implementation of the connection optimization can be found on branch hotfix/2-connection.

[PurHur]

Now we connect to the server on every mail test. Thats even more connections.

[jsmmo]

???? is this still active?

[pmaasz]

I will have another look at this. I think there is some stuff that needs to be cleaned up.