Skip to content

Commit 199c73e

Browse files
committed
Merge branch 'andrew/get_chrome_path_update' into andrew/update_last_known_good_chrome
2 parents 91a7eb0 + fa4a9ac commit 199c73e

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

src/choreographer/cli/_cli_utils.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
from pathlib import Path
1414

1515
import logistro
16-
from platformdirs import PlatformDirs
1716

1817
from choreographer.cli.defaults import default_download_path
1918

@@ -49,12 +48,7 @@ def get_chrome_download_path() -> Path | None:
4948
if not _chrome_platform_detected:
5049
return None
5150

52-
_default_exe_path = (
53-
Path(
54-
PlatformDirs("choreographer", "plotly").user_data_dir,
55-
)
56-
/ "deps"
57-
)
51+
_default_exe_path = default_download_path
5852
_default_exe_path.mkdir(parents=True, exist_ok=True)
5953

6054
if platform.system().startswith("Linux"):

src/choreographer/cli/defaults.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,12 @@
22

33
from pathlib import Path
44

5-
default_download_path = Path(__file__).resolve().parent / "browser_exe"
5+
from platformdirs import PlatformDirs
6+
7+
default_download_path = (
8+
Path(
9+
PlatformDirs("choreographer", "plotly").user_data_dir,
10+
)
11+
/ "deps"
12+
)
613
"""The path where we download chrome if no path argument is supplied."""

0 commit comments

Comments
 (0)