fix: image converting issue fix on productioin mode

Author: pixelnroot

app/Filament/Resources/GenerateNewsResource/Pages/ViewBeforeDownload.php

@@ -46,12 +46,16 @@ public function mount(string $start_date, string $end_date, string $report_title
         if ($saved_report === "no") {
             list($ban, $delta, $global) = News::getNewsByDate($this->start_date, $this->end_date, 'all');
 
-            $html = News::generateHTML( $ban, $delta, $global, 
-            [
-                'start_date' => $this->start_date,
-                'report_title' => $this->report_title,
-                'report_code' => $this->report_code,
-            ]);
+            $html = News::generateHTML(
+                $ban,
+                $delta,
+                $global,
+                [
+                    'start_date' => $this->start_date,
+                    'report_title' => $this->report_title,
+                    'report_code' => $this->report_code,
+                ]
+            );
 
             $this->html = $html;
         } elseif ($saved_report === "yes") {
@@ -138,7 +142,8 @@ public function downloadReportDocx()
         $pythonCmd = escapeshellcmd($venvPython) . " " . escapeshellarg($pythonScript) . " " . escapeshellarg($htmlPath) . " " . escapeshellarg($docxPath) . " 2>&1";
         $output = shell_exec($pythonCmd);
 
-        if (strpos($output, 'Error') !== false || strpos($output, 'Traceback') !== false || !Storage::disk('docx')->exists($docxRelativePath)) {
+        if (!file_exists($docxPath)) {
+            Log::error('DOCX generation failed', ['output' => $output]);
             send_notification('danger', 3000, 'Failed to generate DOCX: ' . $output);
             return;
         }

scripts/generate_docx.py

@@ -97,21 +97,32 @@ def normalize_text(text):
         raise
 
 def convert_image_to_png(image_path):
-    """Convert an image to PNG if it's in an unsupported format (e.g., WebP)."""
+    """Convert an image to PNG if it's in an unsupported format (e.g., WebP) and validate it."""
     try:
         if not os.access(image_path, os.R_OK):
+            print(f"Error: No read permission for image {image_path}")
             return None
         with Image.open(image_path) as img:
+            img.verify()  # Check if the image is valid
+            img = Image.open(image_path)  # Reopen after verify
+            img.load()  # Force load to catch any issues
+            image_size = img.size
+            print(f"Image {image_path}: format={img.format}, size={image_size}")
+            # Skip images larger than 5000x5000 to prevent memory issues
+            if max(image_size) > 5000:
+                print(f"Error: Image {image_path} too large ({image_size}), skipping")
+                return None
             if img.format.lower() == 'webp':
                 temp_dir = '/var/www/bd-news/storage/app/public'
                 if not os.path.exists(temp_dir):
                     os.makedirs(temp_dir)
                 temp_file = os.path.join(temp_dir, f"temp_{uuid.uuid4().hex}.png")
                 img.save(temp_file, 'PNG')
+                print(f"Converted WebP to PNG: {image_path} -> {temp_file}")
                 return temp_file
             return image_path
     except Exception as e:
-        print(f"Error converting image {image_path}: {str(e)}")
+        print(f"Error validating or converting image {image_path}: {str(e)}")
         return None
 
 def get_style_safe(doc, style_name, fallback_style='Normal'):
@@ -219,6 +230,7 @@ def process_element(element, doc, current_para=None, indent=0, html_path=None):
         elif element.name == 'img':
             src = element.get('src')
             if not src:
+                print(f"Warning: Image tag missing src attribute")
                 return current_para
             original_src = src
             if src.startswith(('http://', 'https://')):
@@ -236,11 +248,14 @@ def process_element(element, doc, current_para=None, indent=0, html_path=None):
             src = urllib.parse.unquote(src)
             src = src.replace('/storage/app/public/storage/', '/storage/app/public/')
             if not os.path.exists(src):
+                print(f"Warning: Image file not found at {src} (original: {original_src})")
                 return current_para
             if not os.access(src, os.R_OK):
+                print(f"Error: No read permission for image {src}")
                 return current_para
             embed_path = convert_image_to_png(src)
             if not embed_path:
+                print(f"Error: Failed to prepare image {src} for embedding")
                 return current_para
             if current_para is None:
                 current_para = doc.add_paragraph()
@@ -250,18 +265,24 @@ def process_element(element, doc, current_para=None, indent=0, html_path=None):
                 run = current_para.add_run()
                 style = parse_style(element.get('style', ''))
                 width = style.get('width', element.get('width', '300px'))
-                width_match = re.match(r'(\d+)\s*px', width)
-                width_inches = Inches(3)
+                print(f"Processing image {src}: width attribute={width}")
+                width_match = re.match(r'(\d+)\s*px', str(width))
+                width_inches = Inches(3)  # Default width
                 if width_match:
                     width_inches = Inches(float(width_match.group(1)) / 96)
+                else:
+                    print(f"Warning: Invalid width format '{width}' for image {src}, using default 3 inches")
                 run.add_picture(embed_path, width=width_inches)
+                print(f"Successfully embedded image: {src}")
             except Exception as e:
-                run = current_para.add_run(f"[Image failed to embed: {src} {embed_path} {os.path.exists(embed_path)}]")
+                print(f"Error embedding image {src}: {str(e)}")
+                run = current_para.add_run(f"[Image failed to embed: {os.path.basename(src)} | Error: {str(e)} | Path exists: {os.path.exists(embed_path)}]")
                 run.font.color.rgb = RGBColor(255, 0, 0)  # Red text for error
             finally:
                 if embed_path != src and os.path.exists(embed_path):
                     try:
                         os.unlink(embed_path)
+                        print(f"Deleted temporary file: {embed_path}")
                     except Exception as e:
                         print(f"Error deleting temporary file {embed_path}: {str(e)}")
         elif element.name == 'table':