fix(BulkSelect): hoist default label functions to prevent useMemo invalidation

The inline arrow function defaults were creating new function references
on every render, breaking useMemo optimization. This caused dropdown
items to recompute on every render instead of only when dependencies
changed.

Fixed by hoisting default label functions to module-level constants,
ensuring stable references across renders and proper memoization.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: rhamilto

packages/module/src/BulkSelect/BulkSelect.tsx

@@ -22,6 +22,10 @@ export const BulkSelectValue = {
 
 export type BulkSelectValue = (typeof BulkSelectValue)[keyof typeof BulkSelectValue];
 
+const defaultSelectPageLabel = (pageCount?: number) => `Select page${pageCount ? ` (${pageCount})` : ''}`;
+const defaultSelectAllLabel = (totalCount?: number) => `Select all${totalCount ? ` (${totalCount})` : ''}`;
+const defaultSelectedLabel = (count: number) => `${count} selected`;
+
 /** extends DropdownProps */
 export interface BulkSelectProps extends Omit<DropdownProps, 'toggle' | 'onSelect'> {
   /** BulkSelect className */
@@ -74,13 +78,17 @@ export const BulkSelect: FC<BulkSelectProps> = ({
   dropdownListProps,
   menuToggleProps,
   selectNoneLabel = 'Select none (0)',
-  selectPageLabel = (pageCount?: number) => `Select page${pageCount ? ` (${pageCount})` : ''}`,
-  selectAllLabel = (totalCount?: number) => `Select all${totalCount ? ` (${totalCount})` : ''}`,
-  selectedLabel = (count: number) => `${count} selected`,
+  selectPageLabel = defaultSelectPageLabel,
+  selectAllLabel = defaultSelectAllLabel,
+  selectedLabel = defaultSelectedLabel,
   ...props
 }: BulkSelectProps) => {
   const [ isOpen, setOpen ] = useState(false);
 
+  // Compute label text to use as memo dependencies for i18n support
+  const selectPageLabelText = selectPageLabel(pageCount);
+  const selectAllLabelText = selectAllLabel(totalCount);
+
   const splitButtonDropdownItems = useMemo(
     () => (
       <>
@@ -89,17 +97,17 @@ export const BulkSelect: FC<BulkSelectProps> = ({
         </DropdownItem>
         {isDataPaginated && (
           <DropdownItem ouiaId={`${ouiaId}-select-page`} value={BulkSelectValue.page} key={BulkSelectValue.page}>
-            {selectPageLabel(pageCount)}
+            {selectPageLabelText}
           </DropdownItem>
         )}
         {canSelectAll && (
           <DropdownItem ouiaId={`${ouiaId}-select-all`} value={BulkSelectValue.all} key={BulkSelectValue.all}>
-            {selectAllLabel(totalCount)}
+            {selectAllLabelText}
           </DropdownItem>
         )}
       </>
     ),
-    [ isDataPaginated, canSelectAll, ouiaId, pageCount, totalCount, selectNoneLabel, selectPageLabel, selectAllLabel ]
+    [ isDataPaginated, canSelectAll, ouiaId, selectNoneLabel, selectPageLabelText, selectAllLabelText ]
   );
 
   const allOption = isDataPaginated ? BulkSelectValue.page : BulkSelectValue.all;