-
Notifications
You must be signed in to change notification settings - Fork 6
Migration Issues Random Walks #190
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workingdagstuhldocumentationImprovements or additions to documentationImprovements or additions to documentationhelp wantedExtra attention is neededExtra attention is needed
Milestone
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdagstuhldocumentationImprovements or additions to documentationImprovements or additions to documentationhelp wantedExtra attention is neededExtra attention is needed
Type
Fields
Give feedbackNo fields configured for issues without a type.
As far as I am aware, we reused the PathPy3 code for the implementation of the random walks. I noticed the following problems that need to be fixed:
transition_probabilities(...)(fixed in Minor Fixes for Random Walks #189)rw.plot(...)which does not work in pathpyG as far as I know.HigherOrderRandomWalk.first_order_stationary_state(...):v.relations[-1]throws an exception since each node is an id (tuple or string) and not a node object as in pathpy3.process.py: More than half of the file is commented out and marked as TODO.There are probably some more problems that I haven't noticed so far, so I propose some additional unit-tests for each file in
processes/:process.pyrandom_walk.pysampling.py(see VoseAliasSampling slow for many samples #217 )