📊 Expand indicator paths for x, size, color dimensions#5869
Open
Marigold wants to merge 5 commits into
Open
Conversation
Contributor
|
Quick links (staging server):
Login: chart-diff: ✅No charts for review.data-diff: ✅ No differences foundAutomatically updated datasets matching excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included Edited: 2026-03-31 12:51:21 UTC |
- Add additional_indicators param to expand_config/create_collection - Auto-expand short paths in Collection.save() for post-creation indicators - Update incomes_wid.py and dummy.py to use short paths Closes #5665
d2fa7b1 to
297e20d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5665
Expand indicator paths for
x,size, andcolordimensions — previously onlyywas supported.What changed
1.
expand_config()/create_collection()now acceptadditional_indicatorsAdds
x/size/colorindicators to every auto-generated view during expansion:Short paths are expanded using the same logic as
yindicators; paths with#or full catalog paths are kept as-is.2.
Collection.save()now auto-expands short paths added after creationPreviously, path expansion only ran once during
create_collection(). If you addedx/size/colorindicators after that (e.g. aftergroup_views), you had to hardcode full catalog paths. Nowsave()re-runsexpand_paths()before validation — already-complete paths are safely skipped.This enables the pattern from the issue:
3. Updated real-world steps to use short paths
incomes_wid.py— the exact example from the issuedummy.py— also used a full path forcolorTesting
expand_path_modevalues, invalid axis validation, and combined withcommon_view_config