Compilation errors in Eclipse and IntelliJ

[erizzo]

I just cloned the repo and imported into Eclipse, set the project to use Java 25.
There are compilation errors in 2 classes, AbstractObjectAssert and AbstractIterableAssert, all centered around typing errors.

In AbstractObjectAssert the same error shows up on 4 different lines. Here's one example, line 467

  public AbstractObjectAssert<?, ?> extracting(String propertyOrField) {
    return super.extracting(propertyOrField, this::newObjectAssert);
  }

The type of newObjectAssert(Object) from the type AbstractObjectAssert<SELF,ACTUAL> is AbstractObjectAssert<?,Object>, this is incompatible with the descriptor's return type: AbstractObjectAssert<AbstractObjectAssert<AbstractObjectAssert<?,Object>,Object>,Object>

In AbstractIterableAssert, there are 2 instances of a different error. One example, line 3011:

  private ELEMENT lastElement() {
    if (actual instanceof List<? extends ELEMENT> list) {
      return list.get(list.size() - 1);
    }

Type ACTUAL cannot be safely cast to List<? extends ELEMENT>

Only the AbstractIterableAssert errors show up in IntelliJ.

Has anyone else run into these compilation errors?

[scordio]

Thanks for the heads up, @erizzo!

I personally use IntelliJ, and I see the same AbstractIterableAssert issue:

Still, IntelliJ compiles that correctly... and I'm wondering how everything is fine under Maven 🤔

[sormuras]

Those red lines usually don't come from javac - they are produced by some dedicated syntax parser/compiler thingy in IDEA. QDox, IIRC. Might be a similar issue as documented here: https://youtrack.jetbrains.com/issue/IDEA-269534/Parsing-module-info.java-with-text-blocks-in-annotation-usage-fails#focus=Comments-27-4904856.0-0

[erizzo]

I'm able to get past the IDE errors in AbstractIterableAssert by changing this:

    if (actual instanceof List<? extends ELEMENT> list) {
      elementAtIndex = list.get(index);
    } else {

to this:

    if (actual instanceof List list) {
      elementAtIndex = (ELEMENT) list.get(index);
    } else {

That leaves warnings in both IntelliJ and Eclipse, but at least not errors.

[erizzo]

Similarly in AbstractObjectAssert, changing this:

    return super.extracting(propertyOrField, this::newObjectAssert);

to this:

    AssertFactory<Object, AbstractObjectAssert<?, Object>> assertFactory = this::newObjectAssert;
    return super.extracting(propertyOrField, assertFactory);

makes Eclipse happy.

[scordio]

Thanks for the additional details, @erizzo!

I have converted this discussion into issue #3996 and will follow up on the investigation there.