Revert "WEB-874 Prevent negative values in numeric fields of Group (#3412)"

This reverts commit 547bb91.

Author: IOhacker

src/app/loans/loans-account-stepper/loans-account-terms-step/loans-account-terms-step.component.html

@@ -55,7 +55,6 @@ <h4 class="mat-h4 flex-98">
           mifosxPositiveNumber
           min="0"
           formControlName="repaymentEvery"
-          min="0"
           matTooltip="{{ 'tooltips.Fields are input to calculating the repayment schedule' | translate }}"
         />
         @if (loansAccountTermsForm.controls.repaymentEvery.hasError('required')) {
@@ -64,9 +63,6 @@ <h4 class="mat-h4 flex-98">
             <strong>{{ 'labels.commons.required' | translate }}</strong>
           </mat-error>
         }
-        @if (loansAccountTermsForm.controls.repaymentEvery.hasError('min')) {
-          <mat-error> {{ 'labels.inputs.Repaid every' | translate }} must be at least <strong>0</strong> </mat-error>
-        }
       </mat-form-field>
 
       <mat-form-field class="flex-23">
@@ -116,16 +112,13 @@ <h4 class="mat-h4 flex-98">
     @if (loanProductService.isLoanProduct) {
       <mat-form-field class="flex-fill flex-23">
         <mat-label>{{ 'labels.inputs.Loan Term' | translate }}</mat-label>
-        <input type="number" matInput required formControlName="loanTermFrequency" min="0" />
+        <input type="number" matInput required formControlName="loanTermFrequency" />
         @if (loansAccountTermsForm.controls.loanTermFrequency.hasError('required')) {
           <mat-error>
             {{ 'labels.inputs.Loan Term' | translate }} {{ 'labels.commons.is' | translate }}
             <strong>{{ 'labels.commons.required' | translate }}</strong>
           </mat-error>
         }
-        @if (loansAccountTermsForm.controls.loanTermFrequency.hasError('min')) {
-          <mat-error> {{ 'labels.inputs.Loan Term' | translate }} must be at least <strong>0</strong> </mat-error>
-        }
       </mat-form-field>
 
       <mat-form-field class="flex-fill flex-23">
@@ -165,7 +158,6 @@ <h4 class="mat-h4 flex-98">{{ 'labels.inputs.Repayments' | translate }}</h4>
           type="number"
           matInput
           formControlName="numberOfRepayments"
-          min="0"
           matTooltip="{{ 'tooltips.Enter the total count of repayments' | translate }}"
         />
         @if (loansAccountTermsForm.controls.numberOfRepayments.hasError('required')) {
@@ -174,11 +166,6 @@ <h4 class="mat-h4 flex-98">{{ 'labels.inputs.Repayments' | translate }}</h4>
             <strong>{{ 'labels.commons.required' | translate }}</strong>
           </mat-error>
         }
-        @if (loansAccountTermsForm.controls.numberOfRepayments.hasError('min')) {
-          <mat-error>
-            {{ 'labels.inputs.Number of repayments' | translate }} must be at least <strong>0</strong>
-          </mat-error>
-        }
       </mat-form-field>
 
       @if (loansAccountTermsData?.canDefineInstallmentAmount) {
@@ -231,7 +218,6 @@ <h4 class="mat-h4 flex-98">
           matInput
           required
           formControlName="repaymentEvery"
-          min="0"
           matTooltip="{{ 'tooltips.Fields are input to calculating the repayment schedule' | translate }}"
         />
         @if (loansAccountTermsForm.controls.repaymentEvery.hasError('required')) {
@@ -240,9 +226,6 @@ <h4 class="mat-h4 flex-98">
             <strong>{{ 'labels.commons.required' | translate }}</strong>
           </mat-error>
         }
-        @if (loansAccountTermsForm.controls.repaymentEvery.hasError('min')) {
-          <mat-error> {{ 'labels.inputs.Repaid every' | translate }} must be at least <strong>0</strong> </mat-error>
-        }
       </mat-form-field>
 
       <mat-form-field class="flex-fill flex-23">
@@ -304,12 +287,7 @@ <h4 class="mat-h4 flex-98">{{ 'labels.inputs.Nominal interest rate' | translate
       @if (!loansAccountTermsData?.isLoanProductLinkedToFloatingRate) {
         <mat-form-field class="flex-fill flex-23">
           <mat-label>{{ 'labels.inputs.Nominal interest rate' | translate }} %</mat-label>
-          <input type="number" matInput formControlName="interestRatePerPeriod" min="0.01" step="0.01" />
-          @if (loansAccountTermsForm.controls.interestRatePerPeriod.hasError('min')) {
-            <mat-error>
-              {{ 'labels.inputs.Nominal interest rate' | translate }} must be at least <strong>0.01</strong>
-            </mat-error>
-          }
+          <input type="number" matInput formControlName="interestRatePerPeriod" />
         </mat-form-field>
         <mat-form-field class="flex-fill flex-23">
           <mat-label>{{ 'labels.inputs.Frequency' | translate }}</mat-label>
@@ -490,30 +468,17 @@ <h4 class="mat-h4 flex-98">{{ 'labels.heading.Interest Calculations' | translate
           matInput
           type="number"
           formControlName="inArrearsTolerance"
-          min="0"
           matTooltip="{{ 'tooltips.With Arrears tolerance' | translate }}"
         />
-        @if (loansAccountTermsForm.controls.inArrearsTolerance.hasError('min')) {
-          <mat-error>
-            {{ 'labels.inputs.Arrears tolerance' | translate }} must be at least <strong>0</strong>
-          </mat-error>
-        }
       </mat-form-field>
 
       <mat-form-field class="flex-48">
         <mat-label>{{ 'labels.inputs.Interest free period' | translate }}</mat-label>
         <input
           matInput
-          type="number"
           formControlName="graceOnInterestCharged"
-          min="0"
           matTooltip="{{ 'tooltips.If the Interest Free Period' | translate }}"
         />
-        @if (loansAccountTermsForm.controls.graceOnInterestCharged.hasError('min')) {
-          <mat-error>
-            {{ 'labels.inputs.Interest free period' | translate }} must be at least <strong>0</strong>
-          </mat-error>
-        }
       </mat-form-field>
 
       <h4 class="mat-h4 flex-98">
@@ -523,32 +488,17 @@ <h4 class="mat-h4 flex-98">
 
       <mat-form-field class="flex-fill flex-23">
         <mat-label>{{ 'labels.inputs.Grace on principal payment' | translate }}</mat-label>
-        <input type="number" matInput formControlName="graceOnPrincipalPayment" min="0" />
-        @if (loansAccountTermsForm.controls.graceOnPrincipalPayment.hasError('min')) {
-          <mat-error>
-            {{ 'labels.inputs.Grace on principal payment' | translate }} must be at least <strong>0</strong>
-          </mat-error>
-        }
+        <input type="number" matInput formControlName="graceOnPrincipalPayment" />
       </mat-form-field>
 
       <mat-form-field class="flex-fill flex-23">
         <mat-label>{{ 'labels.inputs.Grace on interest payment' | translate }}</mat-label>
-        <input type="number" matInput formControlName="graceOnInterestPayment" min="0" />
-        @if (loansAccountTermsForm.controls.graceOnInterestPayment.hasError('min')) {
-          <mat-error>
-            {{ 'labels.inputs.Grace on interest payment' | translate }} must be at least <strong>0</strong>
-          </mat-error>
-        }
+        <input type="number" matInput formControlName="graceOnInterestPayment" />
       </mat-form-field>
 
       <mat-form-field class="flex-48">
         <mat-label>{{ 'labels.inputs.On arrears ageing' | translate }}</mat-label>
-        <input type="number" matInput formControlName="graceOnArrearsAgeing" min="0" />
-        @if (loansAccountTermsForm.controls.graceOnArrearsAgeing.hasError('min')) {
-          <mat-error>
-            {{ 'labels.inputs.On arrears ageing' | translate }} must be at least <strong>0</strong>
-          </mat-error>
-        }
+        <input type="number" matInput formControlName="graceOnArrearsAgeing" />
       </mat-form-field>
 
       @if (isDelinquencyEnabled()) {

src/app/loans/loans-account-stepper/loans-account-terms-step/loans-account-terms-step.component.ts

@@ -496,36 +496,6 @@ export class LoansAccountTermsStepComponent extends LoanProductBaseComponent imp
         repaymentFrequencyDayOfWeekType.updateValueAndValidity();
       });
     });
-    const numericFieldsWithMinZero = [
-      'graceOnPrincipalPayment',
-      'graceOnInterestPayment',
-      'graceOnArrearsAgeing',
-      'inArrearsTolerance',
-      'graceOnInterestCharged',
-      'loanTermFrequency',
-      'numberOfRepayments',
-      'repaymentEvery'
-    ];
-
-    numericFieldsWithMinZero.forEach((fieldName) => {
-      const control = this.loansAccountTermsForm.get(fieldName);
-      if (control) {
-        control.valueChanges.subscribe((value) => {
-          if (typeof value === 'number' && value < 0) {
-            control.setValue(0, { emitEvent: false });
-          }
-        });
-      }
-    });
-
-    const interestRateControl = this.loansAccountTermsForm.get('interestRatePerPeriod');
-    if (interestRateControl) {
-      interestRateControl.valueChanges.subscribe((value) => {
-        if (typeof value === 'number' && value < 0.01) {
-          interestRateControl.setValue(0.01, { emitEvent: false });
-        }
-      });
-    }
   }
 
   /** Custom Listeners for the form to calculate Loan Term */
@@ -599,28 +569,19 @@ export class LoansAccountTermsStepComponent extends LoanProductBaseComponent imp
         ],
         loanTermFrequency: [
           { value: '', disabled: true },
-          [
-            Validators.required,
-            Validators.min(0)
-          ]
+          Validators.required
         ],
         loanTermFrequencyType: [
           '',
           Validators.required
         ],
         numberOfRepayments: [
           '',
-          [
-            Validators.required,
-            Validators.min(0)
-          ]
+          Validators.required
         ],
         repaymentEvery: [
           '',
-          [
-            Validators.required,
-            Validators.min(0)
-          ]
+          Validators.required
         ],
         repaymentFrequencyType: [
           { value: '', disabled: true },
@@ -630,10 +591,7 @@ export class LoansAccountTermsStepComponent extends LoanProductBaseComponent imp
         repaymentFrequencyDayOfWeekType: [''],
         repaymentsStartingFromDate: [''],
         interestChargedFromDate: [''],
-        interestRatePerPeriod: [
-          '',
-          Validators.min(0.01)
-        ],
+        interestRatePerPeriod: [''],
         interestType: [''],
         isFloatingInterestRate: [null],
         isEqualAmortization: [''],
@@ -643,26 +601,11 @@ export class LoansAccountTermsStepComponent extends LoanProductBaseComponent imp
         ],
         interestCalculationPeriodType: [''],
         allowPartialPeriodInterestCalculation: [''],
-        inArrearsTolerance: [
-          '',
-          Validators.min(0)
-        ],
-        graceOnInterestCharged: [
-          '',
-          Validators.min(0)
-        ],
-        graceOnPrincipalPayment: [
-          '',
-          Validators.min(0)
-        ],
-        graceOnInterestPayment: [
-          '',
-          Validators.min(0)
-        ],
-        graceOnArrearsAgeing: [
-          '',
-          Validators.min(0)
-        ],
+        inArrearsTolerance: [''],
+        graceOnInterestCharged: [''],
+        graceOnPrincipalPayment: [''],
+        graceOnInterestPayment: [''],
+        graceOnArrearsAgeing: [''],
         loanIdToClose: [''],
         fixedEmiAmount: [''],
         isTopup: [''],

src/app/savings/savings-account-stepper/savings-account-terms-step/savings-account-terms-step.component.html

@@ -20,16 +20,11 @@
 
     <mat-form-field class="flex-48">
       <mat-label>{{ 'labels.inputs.Nominal Annual Interest' | translate }}</mat-label>
-      <input type="number" matInput formControlName="nominalAnnualInterestRate" required min="0" step="0.01" />
-      @if (savingsAccountTermsForm.controls.nominalAnnualInterestRate.hasError('required')) {
-        <mat-error>
-          {{ 'labels.inputs.Nominal Annual Interest' | translate }} {{ 'labels.commons.is' | translate }}
-          <strong>{{ 'labels.commons.required' | translate }}</strong>
-        </mat-error>
-      }
-      @if (savingsAccountTermsForm.controls.nominalAnnualInterestRate.hasError('min')) {
-        <mat-error> {{ 'labels.inputs.Nominal Annual Interest' | translate }} must be zero or greater </mat-error>
-      }
+      <input type="number" matInput formControlName="nominalAnnualInterestRate" required />
+      <mat-error>
+        {{ 'labels.inputs.Nominal Annual Interest' | translate }} {{ 'labels.commons.is' | translate }}
+        <strong>{{ 'labels.commons.required' | translate }}</strong>
+      </mat-error>
     </mat-form-field>
 
     <mat-form-field class="flex-48">
@@ -97,7 +92,7 @@
 
     <mat-form-field class="flex-48">
       <mat-label>{{ 'labels.inputs.Minimum Opening Balance' | translate }}</mat-label>
-      <input type="number" matInput formControlName="minRequiredOpeningBalance" min="0" />
+      <input type="number" matInput formControlName="minRequiredOpeningBalance" />
     </mat-form-field>
 
     <mat-checkbox labelPosition="before" formControlName="withdrawalFeeForTransfers" class="margin-v flex-48">
@@ -108,7 +103,7 @@ <h4 class="mat-h4 flex-98">{{ 'labels.inputs.Lock-in Period' | translate }}</h4>
 
     <mat-form-field class="flex-48">
       <mat-label>{{ 'labels.inputs.Frequency' | translate }}</mat-label>
-      <input type="number" matInput formControlName="lockinPeriodFrequency" min="0" />
+      <input type="number" matInput formControlName="lockinPeriodFrequency" />
     </mat-form-field>
 
     <mat-form-field class="flex-48">
@@ -134,15 +129,15 @@ <h3 class="mat-h3 flex-23">{{ 'labels.inputs.Overdraft' | translate }}</h3>
       <div class="flex-fill layout-row-wrap gap-2percent responsive-column">
         <mat-form-field class="flex-31">
           <mat-label>{{ 'labels.inputs.Minimum Overdraft Required for Interest Calculation' | translate }}</mat-label>
-          <input type="number" matInput formControlName="minOverdraftForInterestCalculation" min="0" />
+          <input type="number" matInput formControlName="minOverdraftForInterestCalculation" />
         </mat-form-field>
         <mat-form-field class="flex-31">
           <mat-label>{{ 'labels.inputs.Nominal Annual Interest for Overdraft' | translate }}</mat-label>
-          <input type="number" matInput formControlName="nominalAnnualInterestRateOverdraft" min="0" />
+          <input type="number" matInput formControlName="nominalAnnualInterestRateOverdraft" />
         </mat-form-field>
         <mat-form-field class="flex-31">
           <mat-label>{{ 'labels.inputs.Maximum Overdraft Amount Limit' | translate }}</mat-label>
-          <input type="number" matInput formControlName="overdraftLimit" min="0" />
+          <input type="number" matInput formControlName="overdraftLimit" />
         </mat-form-field>
       </div>
     }
@@ -155,13 +150,13 @@ <h3 class="mat-h3 flex-23">{{ 'labels.inputs.Overdraft' | translate }}</h3>
 
     <mat-form-field class="flex-48">
       <mat-label>{{ 'labels.inputs.Minimum Balance' | translate }}</mat-label>
-      <input type="number" matInput formControlName="minRequiredBalance" min="0" />
+      <input type="number" matInput formControlName="minRequiredBalance" />
     </mat-form-field>
 
     @if (savingsAccountTermsForm.controls.minBalanceForInterestCalculation.value) {
       <mat-form-field class="flex-48">
         <mat-label>{{ 'labels.inputs.Balance Required for Interest Calculation' | translate }}</mat-label>
-        <input type="number" matInput formControlName="minBalanceForInterestCalculation" min="0" />
+        <input type="number" matInput formControlName="minBalanceForInterestCalculation" />
       </mat-form-field>
     }
   </div>