From 739f7d47f97acf71e306f787958ac206efdfe750 Mon Sep 17 00:00:00 2001 From: Matt Carroll Date: Wed, 8 Jul 2026 14:46:58 +1000 Subject: [PATCH 1/2] AP-9511 # Disabled SMS MFA --- src/components/mfa/MfaMethodRow.tsx | 7 ++++++- src/components/mfa/MultiFactorAuthentication.tsx | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/components/mfa/MfaMethodRow.tsx b/src/components/mfa/MfaMethodRow.tsx index f783e807..04a61f26 100644 --- a/src/components/mfa/MfaMethodRow.tsx +++ b/src/components/mfa/MfaMethodRow.tsx @@ -48,6 +48,11 @@ function MfaMethodRow({ onDisable, onSetPreferred, }: Props) { + const smsSetupDisabledTooltip = + cypressPrefix === 'mfa-sms' && !isEnabled + ? 'SMS MFA setup will be available in a future release. Please use Authenticator App in the meantime.' + : undefined + return ( @@ -124,7 +129,7 @@ function MfaMethodRow({ title={ showSetupErrorTooltip ? 'We are unable to load your MFA status. Please try again by clicking the reload button on the chip above.' - : '' + : smsSetupDisabledTooltip ?? '' } > diff --git a/src/components/mfa/MultiFactorAuthentication.tsx b/src/components/mfa/MultiFactorAuthentication.tsx index 902b70cf..fae7d790 100644 --- a/src/components/mfa/MultiFactorAuthentication.tsx +++ b/src/components/mfa/MultiFactorAuthentication.tsx @@ -125,7 +125,7 @@ function MfaMethodList({ isUsedForLogin={isMfaMethodUsedForLogin(mfaSettings, 'sms')} isSettingUp={isSettingUpMfa && settingUpMfaMethod === 'sms'} isSettingPreferredMfaMethod={isSettingPreferredMfaMethod} - isSetupDisabled={!!loadingError || isSettingUpMfa} + isSetupDisabled={!!loadingError || isSettingUpMfa || !mfaSettings.sms.enabled} showSetupErrorTooltip={!!loadingError} title="SMS" description="Receive a one-time verification code via SMS each time MFA is required." From 9833d3af1edbf745bae8152ee8bec1a2d5312e7d Mon Sep 17 00:00:00 2001 From: Matt Carroll Date: Wed, 8 Jul 2026 14:57:10 +1000 Subject: [PATCH 2/2] AP-9511 # Changed cypressPrefix type to explicit strings --- src/components/mfa/MfaMethodRow.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/mfa/MfaMethodRow.tsx b/src/components/mfa/MfaMethodRow.tsx index 04a61f26..82ed4f4e 100644 --- a/src/components/mfa/MfaMethodRow.tsx +++ b/src/components/mfa/MfaMethodRow.tsx @@ -22,7 +22,7 @@ type Props = { detail?: string mfaRequirementMessage?: string mfaRequirementMessageIsWarning?: boolean - cypressPrefix: string + cypressPrefix: 'mfa-authenticator' | 'mfa-sms' extraButtons?: React.ReactNode onSetup: () => void onDisable: () => void