fix: wrap story with suspense and correctly call suspense hook#1059
Open
huang-julien wants to merge 3 commits into
Open
fix: wrap story with suspense and correctly call suspense hook#1059huang-julien wants to merge 3 commits into
huang-julien wants to merge 3 commits into
Conversation
✅ Deploy Preview for nuxt-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
This PR fix how the
app:suspense:resolvehook is called.It adds a decorator to wrap the story with a
Suspenseso when Vue renders, this would correctly mirror how Nuxt triggers theapp:suspense:resolvehook + set isHydrating to false (when true, all abort navigation triggerscreateError+showError)