nbformat's validate(strip_invalid_metadata=...) and validate(repair_duplicate_cell_ids=...) will be deprecated.

[Carreau]

See in particular jupyter/nbformat#282.

Validate mutating its argument is the root of a number of hidden bugs and a potential security issue.

[Carreau]

cc @nicholaswold

[willingc]

cc @MSeal

[Carreau]

Note that you seem to be the only users of these options, so if you are ok with it and like the normalize (that return a fixed copy), then validate, I might be a bit more aggressive to deprecate them.

This is likely to reveal a bunch of other bugs in other frontends show up, as high level apis like nbformat.write/nbformat.writes, did call validate with the default of repair_duplicate_cell_ids=True for example.

[MSeal]

@Carreau totally fine to be more aggressive, this library is still a WIP and that pattern was just convenient to resuse at the time. Happy to refactor to new API constraints.