Skip to content

Issue building typescript #48

Description

@John-H-Smith

Describe the bug
While trying around with the module, I found out that compiling from typescript is throwing an error with the code from the examples.
Errors:

$ npx tsc
node_modules/nordigen-node/dist/types/api/account.d.ts:53:48 - error TS2339: Property 'country' does not exist on type '{ dateFrom: string; dateTo: string; }'.

53     getPremiumTransactions({ dateFrom, dateTo, country }?: {
                                                  ~~~~~~~

node_modules/nordigen-node/dist/types/index.d.ts:8:40 - error TS2339: Property 'baseUrl' does not exist on type '{ secretId: string; secretKey: string; }'.

8     constructor({ secretId, secretKey, baseUrl, }: {
                                         ~~~~~~~


Found 2 errors in 2 files.

Errors  Files
     1  node_modules/nordigen-node/dist/types/api/account.d.ts:53
     1  node_modules/nordigen-node/dist/types/index.d.ts:8

To Reproduce
Implement that code in your app:

let client = new NordigenClient({
    secretId: 'censored',
    secretKey: 'censored'
});
await client.generateToken();

let inst = await client.institution.getInstitutions({ country: 'LV' });
console.log(inst);

Then let typescript compile.

tsconfig.json:

{
    "compilerOptions": {
      "module": "ES6",
      "esModuleInterop": true,
      "target": "ES6",
      "moduleResolution": "node",
      "sourceMap": true,
      "outDir": "dist",
      "strict": true,
      "typeRoots": [
        "node_modules/@types"
      ],
      "forceConsistentCasingInFileNames": true
    },
    "lib": [ "esnext", "dom", "dom.iterable" ]
}

Expected behavior
Building should be successful.

Additional context
Running with nodemon and ts-node is working as expected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions