Issue with findProjectRoot within utils.js

[jonathan-fielding]

Hello

So I have noticed an issue with the way in which findProjectRoot attempts to find the project root. By doing a indexOf('node_modules) it sometimes gets confused by some file paths:

Example:

/Users/jonathan/Sites/_beamly_node_modules/whitelabel/node_modules/beamly-js-lint/dist

The expected project route should be

/Users/jonathan/Sites/_beamly_node_modules/whitelabel/

But instead the project route is

/Users/jonathan/Sites

This unfortunately is incorrect, because of the indexOf it is finding the directory I store my modules in _beamly_node_modules

Perhaps a valid fall back if it doesnt find a package.json like that would be to use process.cwd() to find the package.json

Thanks

Jonathan

[nlf]

ah.. you're right. i'll have to change the logic so it splits the path on Path.sep and then looks for 'node_modules' in the resulting array.

[jonathan-fielding]

I was going to make a pull request but I realised my fix actually breaks windows support

[nlf]

how you can fix this and preserve windows support is by doing Path.sep + 'node_modules' + Path.sep instead of hard coding the /