Merge pull request #309 from nitrobass24/release/v0.14.2

Release v0.14.2 — Security, type safety, E2E testing

Author: nitrobass24

.github/workflows/ci.yml

@@ -49,7 +49,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Set up Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: "3.12"
 
@@ -67,18 +67,18 @@ jobs:
   python-typecheck:
     name: Python Type Check
     runs-on: ubuntu-latest
-    continue-on-error: true
     steps:
       - name: Checkout
         uses: actions/checkout@v6
 
       - name: Set up Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: "3.12"
 
-      - name: Install Pyright
-        run: pip install pyright
+      - name: Install dependencies
+        working-directory: src/python
+        run: pip install -r requirements.txt pyright
 
       - name: Pyright
         working-directory: src/python
@@ -93,7 +93,7 @@ jobs:
         uses: actions/checkout@v6
 
       - name: Set up Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v6
         with:
           python-version: "3.12"
           cache: pip
@@ -172,16 +172,42 @@ jobs:
           cache-from: type=gha,scope=amd64
           cache-to: type=gha,scope=amd64,mode=max
 
-      - name: Test container starts
+      - name: Start container
         run: |
-          docker run -d --name test-container -p 8800:8800 seedsync:test
+          docker run -d --name test-container -p 8800:8800 -e SEEDSYNC_DISABLE_RATE_LIMIT=1 seedsync:test
           for i in $(seq 1 30); do
             curl -sf http://localhost:8800/ && break
             [ "$i" -eq 30 ] && { echo "Container failed to become ready"; docker logs test-container; exit 1; }
             sleep 1
           done
           docker logs test-container
-          docker stop test-container
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v6
+        with:
+          node-version: 22
+
+      - name: Install Playwright
+        working-directory: src/e2e-playwright
+        run: |
+          npm install
+          npx playwright install --with-deps chromium
+
+      - name: Run E2E tests
+        working-directory: src/e2e-playwright
+        run: npx playwright test
+
+      - name: Upload Playwright report
+        if: failure()
+        uses: actions/upload-artifact@v7
+        with:
+          name: playwright-report
+          path: src/e2e-playwright/playwright-report/
+          retention-days: 7
+
+      - name: Stop container
+        if: always()
+        run: docker stop test-container
 
   build-amd64:
     name: Build (amd64)
@@ -334,10 +360,11 @@ jobs:
       && (startsWith(github.ref, 'refs/tags/v') || (github.ref == 'refs/heads/develop' && github.event_name == 'push') || github.event_name == 'workflow_dispatch')
       && needs.unit-test.result == 'success'
       && needs.python-lint.result == 'success'
+      && needs.python-typecheck.result == 'success'
       && needs.python-test.result == 'success'
       && needs.build-amd64.result == 'success'
       && needs.build-arm64.result == 'success'
-    needs: [unit-test, python-lint, python-test, build-amd64, build-arm64]
+    needs: [unit-test, python-lint, python-typecheck, python-test, build-amd64, build-arm64]
     runs-on: ubuntu-latest
     permissions:
       contents: read

.gitignore

@@ -8,3 +8,4 @@ package-lock.json
 src/python/build
 src/python/site
 dev-config/
+/test-results/

CHANGELOG.md

@@ -1,5 +1,30 @@
 # Changelog
 
+## [0.14.2] - 2026-03-23
+
+### Added
+
+- **Playwright E2E test suite** — Replaced legacy Protractor tests with Playwright; 55 tests covering all pages, navigation, themes, and settings (#250)
+- **Pyright type checking enforced in CI** — Completed Pyright phases 3 & 4, fixing 166 type errors to reach 0 errors in basic mode; Pyright check is now required in CI (#249)
+
+### Fixed
+
+- **ModelFile nullable size fields** — `local_size` and `remote_size` are now correctly typed as `number | null` to match the Python backend JSON contract
+
+### Security
+
+- **Reject control characters in filenames** — Decoded filenames containing control characters are now rejected to prevent corrupted file entries and queue command injection (#300)
+- **Redact sensitive credentials from API** — SSH password and key passphrase are no longer exposed in API responses; set handler rejects the redacted sentinel value (#257)
+
+### Changed
+
+- **Angular dependency updates** — Bumped Angular group to latest, jsdom to 29.0.1 (#307, #308)
+- **CI: actions/setup-python v6** — Bumped setup-python action from v5 to v6 (#306)
+
+### Removed
+
+- **Legacy Docker E2E infrastructure** — Cleaned up Protractor Docker Compose files, test images, and fixture data
+
 ## [0.14.1] - 2026-03-18
 
 ### Fixed

Makefile

@@ -1,7 +1,7 @@
 # SeedSync Makefile - Docker Only
 # Simplified build system for containerized deployment
 
-.PHONY: all build build-fresh run stop logs clean test test-image size shell help
+.PHONY: all build build-fresh run stop logs clean test test-image test-e2e test-e2e-headed test-e2e-report size shell help
 
 # Default target
 all: build
@@ -41,6 +41,32 @@ test:
 	docker run --rm -v $(PWD)/src/python:/app/python seedsync-test \
 		pytest tests/unittests -v --tb=short
 
+# Run Playwright E2E tests with a throwaway Docker container
+test-e2e-docker:
+	@docker rm -f seedsync-e2e-test 2>/dev/null || true
+	docker run -d --name seedsync-e2e-test -p 8801:8800 -e SEEDSYNC_DISABLE_RATE_LIMIT=1 ghcr.io/nitrobass24/seedsync:latest
+	@echo "Waiting for container to start..."
+	@for i in $$(seq 1 30); do \
+		curl -sf http://localhost:8801/ > /dev/null 2>&1 && break; \
+		sleep 1; \
+	done
+	cd src/e2e-playwright && BASE_URL=http://localhost:8801 npx playwright test; \
+		exit_code=$$?; \
+		docker rm -f seedsync-e2e-test; \
+		exit $$exit_code
+
+# Run Playwright E2E tests (headless, requires running container on port 8800)
+test-e2e:
+	cd src/e2e-playwright && npx playwright test
+
+# Run Playwright E2E tests (headed, for debugging)
+test-e2e-headed:
+	cd src/e2e-playwright && npx playwright test --headed
+
+# Show Playwright HTML report
+test-e2e-report:
+	cd src/e2e-playwright && npx playwright show-report
+
 # Show image size
 size:
 	@docker images seedsync-seedsync --format "Image size: {{.Size}}"
@@ -64,5 +90,9 @@ help:
 	@echo "  clean       - Remove containers and images"
 	@echo "  test        - Run Python unit tests (in Docker)"
 	@echo "  test-image  - Build cached test image"
+	@echo "  test-e2e-docker - Run E2E tests inside a fresh Docker container"
+	@echo "  test-e2e    - Run Playwright E2E tests (headless)"
+	@echo "  test-e2e-headed - Run E2E tests with browser visible"
+	@echo "  test-e2e-report - Show Playwright HTML report"
 	@echo "  size        - Show image size"
 	@echo "  shell       - Open shell in running container"