ni-python-styleguide 0.5.0 retrofit removed an explicit re-export that was for mypy

[bkeryan]

FYI @dixonjoel @mshafer-NI This is a regression. Mypy with --no-implicit-reexport interprets from X import Y as Y as an explicit re-export: https://mypy.readthedocs.io/en/stable/config_file.html#confval-implicit_reexport

Originally posted by @bkeryan in #1307

AB#3900719

[bkeryan]

@dixonjoel @mshafer-NI

I looked at the revision history to see why it was this way.

• In 5fc0c55 (0.11.0), GrpcChannelPool was added to measurement/service.py
• In f8321f1 (1.2.0) it was split into a private _channelpool submodule
• In f9a5108 (1.3.0) it was moved to a public grpc.channelpool submodule.

In releases/1.2, the _helpers.py submodule included in the examples imported from the old location: https://github.com/ni/measurement-plugin-python/blob/releases/1.2/examples/game_of_life/_helpers.py

from ni_measurementlink_service.measurement.service import (
    GrpcChannelPool,
    MeasurementService,
)

However, in releases/1.3, this import was deleted from _helpers.py.

Later, the package was renamed from ni_measurementlink_service to ni_measurement_plugin_sdk_service, breaking compatibility with old copies of _helpers.py.

Also, the from X import Y as Y syntax only affects mypy with --strict or --no-implicit-reexport; from X import Y is equivalent at run time.

All things considered, I guess it's unlikely that removing this particular explicit re-export will break anyone's code.