Add children classes to PayboxException

[greg0ire]

Affected people are probably not the same depending on the origin of the exception.

• It the exception comes from the merchant, developers are affected, because the code probably needs to be changed
• If the exception comes from the gateway, the application should display a 502 or maybe a 503, beacuse it is probably an outage from paybox
• If the exception comes from the bank, the financial department probably needs to be aware of that.

Likewise, error in code and validation problems should be segregated. Ideally validation problems should only happen on the merchant side, but it could happen further down the chain in case of suspicious activity of the cardholder, for example.

Here is how I organised that:

Exception
├── Error
│   ├── BankErrorException.php
│   ├── GatewayErrorException.php
│   └── MerchantErrorException.php
├── ErrorException.php
├── Validation
│   ├── BankValidationException.php
│   ├── GatewayValidationException.php
│   └── MerchantValidationException.php
├── ValidationException.php
├── Wallet
│   └── CardNotFoundException.php
└── WalletException.php

[soullivaneuh]

Nice idea. But how would you detect different kind of error?

From this? http://www1.paybox.com/espace-integrateur-documentation/dictionnaire-des-donnees/codes-reponses/

[greg0ire]

Yes, exactly. If you get one of these codes, it is probably a BankValidationException. If you fail to contact paybox, then you should throw a GatewayErrorException.

[soullivaneuh]

It is indeed needed, because Paybox not always result on a HTTP error.

See example:

array:8 [▼
  "NUMTRANS" => "0000000000"
  "NUMAPPEL" => "0000000000"
  "NUMQUESTION" => "1032688674"
  "SITE" => "1999888"
  "RANG" => "032"
  "AUTORISATION" => ""
  "CODEREPONSE" => "00001"
  "COMMENTAIRE" => "Mandatory+values+missing+keyword:10+Type:25"
]

This issue is accepting PR. I'll manage it later when I'll have the time for. If anyone want to do it, please comment it first.