disable automatic file/folder sharing + add folder path for approved/rejected files upload

[vladimirsharnin]

How to use GitHub

• Please use the 👍 reaction to show that you are interested into the same feature.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Feature request

Which Nextcloud Version are you currently using: (see administration page)

Nextcloud Hub 10 (31.0.10)

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.

• I am using the Approval app for data in Team Folders. When I create an approval request, the app will share that folder/file with approvers in read-only mode, so Team folder permissions will be overwritten by that share. The approver will lose his editing rights defined by the Team folder permissions (or any other custom rights the approver shall have per the internal process).
• The approved version of the file/folder with files needs to be protected from unauthorized change. It is part of the Document Change Control process. It would be great to copy or transfer the approved/rejected file/folder to another folder in the Team folder that may have custom access permissions (read-only for team members and full access for the document control team).

Describe the solution you'd like
A clear and concise description of what you want to happen.

• It would be great to have an option to disable sharing and rely only on Team folder permissions.
• It would be great to have an option to select a folder where the app copies or transfers the approved/rejected file/folder with assigned Tags as defined by the approval process. This folder should be from one of Team folders and may have custom access permissions (read-only and upload rights for team members and full access for the document control team).

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

The alternative is to manually transfer files from the "Work in progress" folder to the "In Check" folder, and then to the "Released" folder (each folder with custom access permissions). But it is hard to force team members to follow this procedure when you have multiple team members in your project. Your app will be a big help in automating the process.

Additional context
Add any other context or screenshots about the feature request here.

I would add two slider controls, as you have for removing file approval: one to disable sharing and another to activate the selection of folder path for process results upload with Approved or Rejected Tag assigned

[lukasdotcom]

Hi @vladimirsharnin,

1. For the first issue I created a teams folder and it worked like expected with not creating a share. Do you have a minimal example that I can use to reproduce that issue.

2. The second issue would be a duplicate of Lock file for editing after approval #347 which is not planned.

[vladimirsharnin]

Hi @lukasdotcom,

1. For the first issue, it does create a share with limited access if the Advanced Permissions option is active for that Team folder. No share created without the Advanced Permissions. It would be great to have no sharing with the Advanced Permissions as well.
2. For the second question, it is not. In Lock file for editing after approval #347, I requested that the file/folder be locked after approval. But now, instead of locking, I suggest copying the approved or rejected file/folder with tags to a defined destination. This way, we can create a subfolder within a Team Folder to store separately approved or rejected versions. Your app can use approver rights to upload copies of approved or rejected files/folders to that folder.

I hope you can help with that.

[vladimirsharnin]

@lukasdotcom

The app creates a share in the same way if I use an External Storage folder connected via WebDav or SMB.

[lukasdotcom]

Hi @vladimirsharnin,

1. For the first issue I tried recreating it again following these steps. Create team folder for alice and admin using custom group made for the two of them. Create workflow where alice asks for approval and admin approves. Alice creates file in team folder and asks for approval from admin. No share is created and admin has access to it.

2. This seems definitely possible to do and a lot easier than Lock file for editing after approval #347, but I don't currently have the time to implement it.