Build failure with glibc 2.43

[micwoj92]

Hello,
Trying to build naemon 1.5.0 (1.4.4 fails too) with gcc 15.2.1 20260209 fails with following error message:

src/naemon/checks.c: In function 'parse_output':
src/naemon/checks.c:114:19: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
  114 |                 p = strpbrk((const char *) tmp, "|");
      |                   ^
src/naemon/checks.c:141:19: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
  141 |                 p = strpbrk((const char *) tmp, "|");
      |                   ^
cc1: all warnings being treated as errors
make[1]: *** [Makefile:2009: src/naemon/checks.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/build/naemon/src/naemon-git'
make: *** [Makefile:1355: all] Error 2

[sni]

i am unable to reproduce this issue.

even added

AX_CHECK_COMPILE_FLAG([-Wdiscarded-qualifiers], AM_CFLAGS+=" -Wdiscarded-qualifiers")

to the configure.ac.

%>gcc --version
gcc (Debian 15.2.0-12) 15.2.0

Is there anything else you did to compile naemon?

[nook24]

Unfortunately I was also unable to reproduce this at Fedora 43

[root@4f73d6921fb9 naemon-core-1.5.0]# lsb_release -a
LSB Version:    n/a
Distributor ID: Fedora
Description:    Fedora Linux 43 (Container Image)
Release:        43
Codename:       n/a

[root@4f73d6921fb9 naemon-core-1.5.0]# gcc --version
gcc (GCC) 15.2.1 20260123 (Red Hat 15.2.1-7)

Could you please provide more details about your environment? What distro or CPU arch are you using?

[micwoj92]

@sni @nook24
This is what I do in build:

  ./autogen.sh
  ./configure --prefix=/usr \
              --bindir=/usr/bin \
              --datadir="/usr/share/naemon" \
              --libdir="/usr/lib/naemon" \
              --localstatedir="/var/lib/naemon" \
              --sysconfdir="/etc/naemon" \
              --with-pkgconfdir="/etc/naemon" \
              --mandir="/usr/share/man" \
              --with-pluginsdir="/usr/lib/monitoring-plugins" \
              --with-tempdir="/var/cache/naemon" \
              --with-checkresultdir="/var/cache/naemon/checkresults" \
              --with-logdir="/var/log/naemon" \
              --with-initdir="/etc/init.d" \
              --with-logrotatedir="/etc/logrotate.d" \
              --with-naemon-user="naemon" \
              --with-naemon-group="naemon" \
              --with-lockfile="/run/naemon/naemon.pid"

  make

The last version gcc I tested and compile was succesful was 15.2.1 20260103. These are differences: gcc-mirror/gcc@6a64f6c...0b99615
Distro is Arch Linux, standard x86_64.

To check if this is not GCC issue, I also tried building with clang 21.1.8, which also produces error mentioning these lines:

src/naemon/checks.c:114:5: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
  114 |                 p = strpbrk((const char *) tmp, "|");
      |                   ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/naemon/checks.c:141:5: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
  141 |                 p = strpbrk((const char *) tmp, "|");
      |                   ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.

[nook24]

Could it be possible that you are missing a required dependency or so?
I successfully build Naemon in a Docker container (docker run --rm -it archlinux:latest bash)

Arch version

[root@b7f20b030fe4 naemon-core-1.5.0]# cat /etc/os-release
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
VERSION_ID=20260208.0.488728

gcc version

gcc (GCC) 15.2.1 20260209

Steps to reproduce

pacman -Sy  base-devel wget curl vim glib2-devel help2man gperf gcc  gdb  pkgconfig libtool

wget https://github.com/naemon/naemon-core/archive/refs/tags/v1.5.0.tar.gz
tar xfv v1.5.0.tar.gz
cd naemon-core-1.5.0/

./autogen.sh
./configure --prefix=/usr \
            --bindir=/usr/bin \
            --datadir="/usr/share/naemon" \
            --libdir="/usr/lib/naemon" \
            --localstatedir="/var/lib/naemon" \
            --sysconfdir="/etc/naemon" \
            --with-pkgconfdir="/etc/naemon" \
            --mandir="/usr/share/man" \
            --with-pluginsdir="/usr/lib/monitoring-plugins" \
            --with-tempdir="/var/cache/naemon" \
            --with-checkresultdir="/var/cache/naemon/checkresults" \
            --with-logdir="/var/log/naemon" \
            --with-initdir="/etc/init.d" \
            --with-logrotatedir="/etc/logrotate.d" \
            --with-naemon-user="naemon" \
            --with-naemon-group="naemon" \
            --with-lockfile="/run/naemon/naemon.pid"

make
make all

[root@b7f20b030fe4 naemon-core-1.5.0]# ./src/naemon/naemon --version
Naemon Core 1.5.0

[datamuc]

pacman -Sy  base-devel wget curl vim glib2-devel help2man gperf gcc  gdb  pkgconfig libtool

Changing that to

pacman -Syyu  base-devel wget curl vim glib2-devel help2man gperf gcc  gdb  pkgconfig libtool

Should make it reproducable

[micwoj92]

@datamuc no need to use -Syyu, -Syu is sufficient.

So it seems like it's not compiler issue. Seems like this change in glibc?

For ISO C23, the functions bsearch, memchr, strchr, strpbrk, strrchr,
  strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr that return
  pointers into their input arrays now have definitions as macros that
  return a pointer to a const-qualified type when the input argument is
  a pointer to a const-qualified type.

* The aforementioned change in ISO C23 of the declaration of bsearch,
  memchr, strchr, strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr,
  wcsstr, and wmemchr as const-preserving macros can lead to compilation
  issues in code not set up for it. In particular, gnulib snapshots may need
  to be updated.

[nook24]

@micwoj92 Could you please take a look at the Issue #530 and my Pull Request #530 as I think I have found the root cause of this issue.

[nook24]

Resolved with #531

[micwoj92]

Thanks for the fix