Suggestions for non docker improvements

[struan]

From running this locally and not using docker there's a couple of things I noticed that would make it a bit smoother:

• using poetry run in ./script/test
• the docs Gemfile doesn't include webrick which is required for ./script/server to work

[struan]

Also, not sure if I did something wrong but I had to do git submodule init and git submodule update to get the data_common things. Is that something the initial generation can do?

[ajparsons]

Pleased it worked mostly ok through poetry because I never checked outside docker (I think it'd have trouble with the charts in notebooks because that's doing something with selenium and chromedriver as well).

First two should be no problem to add (The docker file contains a config bit not to create a virtualenv, so docker run does nothing, but that's fine as it works in both situations).

The submodule bit is solved in the devcontainer as it calls the various .devcontainer/initalizeCommand scripts (a few different ones for cross platform). I think either all of that should be moved into the script/setup, or more simply in the meantime, script/setup could call that script in the meantime. Because most of my setup is done before hand in the docker image, the setup script is a little bare.

The repo to change should be https://github.com/mysociety/template_data_repo - none of these changes should touch the more fiddly bits of the cookiecuttering so should just be fine to do.

If you end up making the changes, could you stick a few lines in the readme about the setup process?