From 7ff510f4a7bd6698f3917d316cde5c194aebd129 Mon Sep 17 00:00:00 2001 From: aktalk <60124334+aktalk@users.noreply.github.com> Date: Wed, 24 Nov 2021 14:33:52 +0800 Subject: [PATCH] no need use if condition before range --- cachetable.go | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/cachetable.go b/cachetable.go index 1fa75ad..71366e3 100644 --- a/cachetable.go +++ b/cachetable.go @@ -181,10 +181,8 @@ func (table *CacheTable) addInternal(item *CacheItem) { table.Unlock() // Trigger callback after adding an item to cache. - if addedItem != nil { - for _, callback := range addedItem { - callback(item) - } + for _, callback := range addedItem { + callback(item) } // If we haven't set up any expiration check timer or found a more imminent item. @@ -219,18 +217,14 @@ func (table *CacheTable) deleteInternal(key interface{}) (*CacheItem, error) { table.Unlock() // Trigger callbacks before deleting an item from cache. - if aboutToDeleteItem != nil { - for _, callback := range aboutToDeleteItem { - callback(r) - } + for _, callback := range aboutToDeleteItem { + callback(r) } r.RLock() defer r.RUnlock() - if r.aboutToExpire != nil { - for _, callback := range r.aboutToExpire { - callback(key) - } + for _, callback := range r.aboutToExpire { + callback(key) } table.Lock()