Skip to content

Segfault on filename containing a colon #35

@chocolateboy

Description

@chocolateboy

reader: v0.5.0
OS: Linux (Arch)
related?: #9

Setup

$ touch 'Foo Bar Baz.html' 'Foo Bar: Baz.html'

No Colon

$ reader 'Foo Bar Baz.html' > /dev/null && echo OK

OK

Colon

$ reader 'Foo Bar: Baz.html' > /dev/null && echo OK
panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xd2c6ab]

goroutine 1 [running]:
github.com/mrusme/journalist/crawler.(*Crawler).FromAuto(0x0?, 0x0?)
/home/runner/go/pkg/mod/github.com/mrusme/journalist@v1.0.1/crawler/crawler.go:134 +0x2b
github.com/mrusme/journalist/crawler.(*Crawler).GetReadable(0xc0005ada58, 0x80?)
/home/runner/go/pkg/mod/github.com/mrusme/journalist@v1.0.1/crawler/crawler.go:105 +0x58
github.com/mrusme/reader/cmd.MakeReadable(0xc0005adbb0, 0x0?, 0x1)
/home/runner/work/reader/reader/cmd/root.go:74 +0x148
github.com/mrusme/reader/cmd.init.func1(0xc000282e00?, {0xc000401d30, 0x1, 0xf568a6?})
/home/runner/work/reader/reader/cmd/root.go:345 +0x208
github.com/spf13/cobra.(*Command).execute(0x1ab9ca0, {0xc0001920f0, 0x1, 0x1})
/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.9.1/command.go:1019 +0xa7b
github.com/spf13/cobra.(*Command).ExecuteC(0x1ab9ca0)
/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.9.1/command.go:1148 +0x40c
github.com/spf13/cobra.(*Command).Execute(...)
/home/runner/go/pkg/mod/github.com/spf13/cobra@v1.9.1/command.go:1071
github.com/mrusme/reader/cmd.Execute()
/home/runner/work/reader/reader/cmd/root.go:439 +0x272
main.main()
/home/runner/work/reader/reader/reader.go:6 +0xf

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions