[DENG-11122] Don't skip generation of deprecated apps#1441
Merged
Conversation
scholtzan
commented
May 15, 2026
Comment on lines
+3
to
+9
| - bergamot | ||
| - experimenter_backend | ||
| - firefox_echo_show | ||
| - firefox_fire_tv | ||
| - firefox_reality | ||
| - firefox_reality_pc | ||
| - firefox_translations |
Contributor
Author
There was a problem hiding this comment.
these apps are deprecated
Integration report for "this commit"
|
BenWu
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mozilla-hub.atlassian.net/browse/DENG-11122
We had a recent case where deprecating
mozilla_vpnresulted in various artifacts not being generated anymore, which broke lookml validation and existing . See #1438This PR removes the logic that skips generation for deprecated apps. Instead these apps need to leverage the
disallow-namespaces.yamlafter going through the deprecation process.Depends on mozilla/bigquery-etl#9374