Don't allow Phabricator AI reviews on patches that have already landed

[globau]

I just received a notification from Phab of an AI review:

https://phabricator.services.mozilla.com/D456#9938008

This AI review is dated Mar 8 2026, 7:28 PM, this patch landed Jan 31 2018, 4:19 PM.

This is clearly the result of someone experimenting with the AI tool. Clearly there's no value in a review of a patch that landed 8 years ago; this just costs time and money.

Requesting an AI review should only be possible on revisions that are WIP or need review, not after they have landed.

[suhaibmujahid]

As now, for such patches, the button is greyed out:

Clicking on the button will show a warning dialog to confirm:

We could restrict this to users with the editbugs permission, and only allow it for bugs that haven't been closed for too long. WDYT?

[globau]

We could restrict this to users with the editbugs permission, and only allow it for bugs that haven't been closed for too long. WDYT?

100% to both, ty 🙂

editbugs is required for a normal Phab review, so not gating AI-review on that is a problem.

Warning messages have some merit, but actions that will only result in negative value - such as reviews on closed revisions - should be hard blocked.

"Not closed for too long" sounds reasonable, for some definition of "too long" (one month?).