Skip to content

Invalid results for DIA and ELL on GPU backends with LayoutRight #49

@cstyl

Description

@cstyl

When a DiaMatrix or EllMatrix is constructed with Kokkos::LayoutRight returns invalid results on Morpheus::Cuda and Morpheus::HIP for multiply() and update_diagonal() algorithms, due to improper construction of the linearized index in each of the following kernels:

  • update_dia_diagonal_kernel() in core/src/impl/Dia/Kernels/Morpheus_MatrixOperations_Impl.hpp
  • spmv_dia_kernel() in core/src/impl/Dia/Kernels/Morpheus_Multiply_Impl.hpp
  • update_ell_diagonal_kernel() in core/src/impl/Ell/Kernels/Morpheus_MatrixOperations_Impl.hpp
  • spmv_ell_kernel() in core/src/impl/Ell/Kernels/Morpheus_MatrixOperations_Impl.hpp

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions