`cd` command is slow

[amorey]

Thanks for making such a useful tool!

I noticed that the cd command slowed down significantly after installing gvm and I tracked down the issue to this script: $GVM_ROOT/scripts/env/cd. I understand the need for overloading cd but it would be helpful if the function ran faster or alternatively if there was a way to opt-in or opt-out. In my case I'm just using the global go version and most of my use of cd is not go-related so the extra cycles aren't necessary.

Here's my setup:

zsh 5.9 (x86_64-apple-darwin23.0)
gvm v1.0.22
macOS 14.5

[jakrh]

If you don't need go version auto-switching on cd, there is a workaround command unset cd to un-overloading cd.

You can put this command into ~/.bash_profile or ~/.zprofile.

[amorey]

Thanks! I had to add "-f" but this worked:

[[ -s "/path/to/home/.gvm/scripts/gvm" ]] && source "/path/to/home/.gvm/scripts/gvm"
unset -f cd

[ccharon]

just found this because my cd command stopped working after installing gvm. This is somehow unexpected :P

i type "cd Programs" in my home directory and it takes a second or two and then the prompt returns but the directory was not changed.

Using the mentioned "unset -f cd" makes it work again, so there is something broken in the cd script.

Go Version Manager v1.0.22
GNU bash, Version 5.2.37(1)-release
Gentoo Linux

Output when setting GVM_DEBUG=1

me@machine ~ $ cd Programs
Resolving defaults...
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++
defaults_go_name => go1.23.5
defaults_go_pkgset => global
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Resolved default go: go1.23.5
Resolved default pkgset: global

dot_go_version =>
defaults_go_name => go1.23.5

No .go-version found. Using system or default go.

dot_go_pkgset =>

No .go-pkgset found. Using system or default pkgset.
---------- defaults_go_pkgset => global ----------

[u2386]

I think the easiest way is to merge this PR and add the flag GVM_DISABLE_CD_HOOK

[simon-ging]

consider setting it to default true, i found it quite unexpected for software to overload cd.

[stuckj]

Also got here when cd became slow after installing gvm. The workaround is helpful, but given how foundational cd is to using anything in the shell I would also recommend not enabling it by default.