fix: strip ignore directives from go.mod/go.work#143
Open
miguelvr wants to merge 1 commit into
Open
Conversation
Author
|
@milesj would love a review, if possible |
Contributor
|
@miguelvr Can you also contribute the change directly to https://github.com/baz-scm/gomod-parser ? I don't want to have to maintain this going forward. |
Author
@milesj already did! here's the PR baz-scm/gomod-parser#35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Go 1.24's new
ignoredirective in bothgo.modandgo.workfiles. The main changes ensure that the parser can handle and ignore these directives, preventing errors with the current version of thegomod-parser2library.