Fix path handling after cd to deployment root

- Convert source_dir to absolute path before cd'ing
- Use "." for create_directory_structure and acquire_lock
- Use relative path for release_dir since we're already in deployment_root
- Fix unused loop variable in test-race.sh reader loop

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: 2 people

deploy.sh

@@ -244,11 +244,15 @@ main() {
 
     [[ $# -eq 2 ]] || { usage; exit 1; }
 
-    readonly source_dir="$1"
+    local source_dir="$1"
     readonly deployment_root="$2"
 
     [[ -d "$source_dir" ]] || die "Source directory does not exist: $source_dir"
 
+    # Convert to absolute path before cd'ing to deployment_root
+    source_dir="$(cd "$source_dir" && pwd)"
+    readonly source_dir
+
     log "Starting deployment"
     log "Source: $source_dir"
     log "Target: $deployment_root"
@@ -258,14 +262,13 @@ main() {
 
     acquire_lock "."
 
-    create_directory_structure "$deployment_root"
+    create_directory_structure "."
 
     local release_id
     release_id="$(generate_release_id)"
     readonly release_id
-    # Absolute path for logging/external use; activate_release uses relative paths
-    # since we've cd'd to deployment_root
-    readonly release_dir="$deployment_root/releases/$release_id"
+    # Use relative path since we've cd'd to deployment_root
+    readonly release_dir="releases/$release_id"
 
     log "Release ID: $release_id"
 

test-race.sh

@@ -22,7 +22,7 @@ echo ""
 
 # Reader loop - runs in background
 (
-  for i in {1..10000}; do
+  for _ in {1..10000}; do
     cat current/version 2>/dev/null || echo "ENOENT"
   done
 ) > reads.log &