flatland breaking release

[ThomasWaldmann]

discorporate/flatland#75

[ThomasWaldmann]

For moin, it might be good to require flatland < 1.0.0 until some developer tested it with moin.

Guess it only requires some minor changes in moin, if any.

[roland-ruedenauer]

I looked at your CHANGES entry and could not find anything that would clearly indicate a breaking change. But we'll see once you have released 1.0.0.

[ThomasWaldmann]

Check the PRs.

[roland-ruedenauer]

I installed your branch locally using

pip install "flatland@git+https://github.com/ThomasWaldmann/flatland@remove-remainders-of-py2-support"

and found Moin2 to still work without any noticable issue (creating & modifying wiki items).

[ThomasWaldmann]

I have now merged everything I had into master and also updated the change log.

[ThomasWaldmann]

New PR with code to try / review: discorporate/flatland#78

[roland-ruedenauer]

Found no issues testing (navigation, editing, ...) this new branch with moin2 master.

[ThomasWaldmann]

yet another change, discorporate/flatland#80

I wonder how moin worked without that, didn't we use labels for radio/checkbox inputs?

[RogerHaase]

Belated guilty here. The only radio/checkboxes are in User Settings. There were no radio buttons or checkboxes anywhere and they did not work with flatland so I coded around them when I updated User Settings ~5 years ago.

[ThomasWaldmann]

@RogerHaase could you test the fixed flatland code from the PR with updated moin code before I do the flatland release?

[RogerHaase]

OK, will take a couple of days

[RogerHaase]

I found the patch changing the theme selection to radio buttons - 9f9c19f on 2020-03-31.

I remember having trouble getting the change to work, but I cannot find any code that needs to be changed to use the recent Flatland changes.

The generated html looks the same.

old flatland

<dt>
    Theme name
</dt>
<dd class="moin-radio">
        <input type="radio" name="theme_name" value="" id="f_theme_name">
<label class="moin-inline-label" for="f_theme_name_">(System Default)</label><br>
        <input type="radio" name="theme_name" value="basic" id="f_theme_name_basic">
<label class="moin-inline-label" for="f_theme_name_basic">Basic Theme</label><br>
        <input type="radio" name="theme_name" value="focus" id="f_theme_name_focus">
<label class="moin-inline-label" for="f_theme_name_focus">Focus Theme</label><br>
        <input type="radio" name="theme_name" value="modernized" id="f_theme_name_modernized">
<label class="moin-inline-label" for="f_theme_name_modernized">Modernized Theme</label><br>
        <input type="radio" name="theme_name" value="topside" checked="checked" id="f_theme_name_topside">
<label class="moin-inline-label" for="f_theme_name_topside">Topside Theme</label><br>
        <input type="radio" name="theme_name" value="topside_cms" id="f_theme_name_topside_cms">
<label class="moin-inline-label" for="f_theme_name_topside_cms">Topside CMS Theme</label>
</dd>
        


new flatland

<dt>
    Theme name
</dt>
<dd class="moin-radio">
        <input type="radio" name="theme_name" value="" id="f_theme_name">
<label class="moin-inline-label" for="f_theme_name_">(System Default)</label><br>
        <input type="radio" name="theme_name" value="basic" id="f_theme_name_basic">
<label class="moin-inline-label" for="f_theme_name_basic">Basic Theme</label><br>
        <input type="radio" name="theme_name" value="focus" id="f_theme_name_focus">
<label class="moin-inline-label" for="f_theme_name_focus">Focus Theme</label><br>
        <input type="radio" name="theme_name" value="modernized" id="f_theme_name_modernized">
<label class="moin-inline-label" for="f_theme_name_modernized">Modernized Theme</label><br>
        <input type="radio" name="theme_name" value="topside" checked="checked" id="f_theme_name_topside">
<label class="moin-inline-label" for="f_theme_name_topside">Topside Theme</label><br>
        <input type="radio" name="theme_name" value="topside_cms" id="f_theme_name_topside_cms">
<label class="moin-inline-label" for="f_theme_name_topside_cms">Topside CMS Theme</label>
</dd>

[ThomasWaldmann]

There is macro _valued_label in forms.html implementing a workaround for old flatland that should not be needed anymore when using the new code correctly.

https://github.com/discorporate/flatland/pull/80/commits (see the docs update in the commit there)