mw stack deploy should warn if items would be overwritten

[CSchulz]

Is your feature request related to a problem? Please describe.
I was trying to deploy my first stack via docker-compose.yml and deleted all other running containers in that stack.

Describe the solution you'd like
There should be a clear warning that there will be containers which gets deleted.

[martin-helmich]

Ah. I see how this can be annoying and surprising. 🙄

The technical reason behind this is that the PUT /v2/stacks/:id route¹ expects (as input) the entire stack, in a declarative manner (meaning any containers that are not included in the updated stack definition are interpreted as to-be-deleted).

However, I do agree that the current mw stack deploy command does not make this behaviour sufficiently clear, so it might be surprising (and not in a good way).

I still don't have a good idea how to solve this, and would be curious about your input. These are my current thoughts:

1. When using the command interactively, we could determine which containers would be deleted by the command, and then have the user confirm the deletion interactively (just like with a delete command).
2. In addition, we could add a --force flag (again, similar to the delete commands) to skip this kind of prompt.
3. When using the command non-interactively (for example, in a deployment script), I'm still unsure. 🤔 We could simply throw an error when a container would be deleted (except when the previously proposed --force flag is set). That might also be surprising, though (and would technically be a breaking change).
4. Alternatively, we could change the implementation to use the PATCH /v2/stacks/:id route²; in this case, containers that are omitted are simply interpreted as "don't touch these", but this would come at the cost of not being able to delete containers using mw stack deploy any longer.

WDYT?

Footnotes

1. https://developer.mittwald.de/docs/v2/reference/container/container-declare-stack/ ↩

2. https://developer.mittwald.de/docs/v2/reference/container/container-update-stack/ ↩