This repository was archived by the owner on Sep 26, 2025. It is now read-only.
Updates required for Heroku Deploy to work out of box.#40
Open
indagation wants to merge 1 commit into
Open
Conversation
Member
|
Oh wow, this repo doesn't have Travis or Coverage set up? @indagation have you run the tests locally to see that things pass with your code changes? I'm actually wondering if you should split the docs and the code into separate PRs. @mitodl/devops do you have an opinion about making the key optional? I actually can't remember why went that route -- I don't expect you know either though. |
Author
|
I have tested and run the sample app. It deploys properly and runs in the state that I submitted. It currently breaks in its existing state on three accounts, python version, ssl considerations caused by the consumer_key_pem, and uwsgi version.
… On Feb 25, 2019, at 11:02 AM, Peter Pinch ***@***.***> wrote:
Oh wow, this repo doesn't have Travis or Coverage set up?
@indagation <https://github.com/indagation> have you run the tests locally to see that things pass with your code changes? I'm actually wondering if you should split the docs and the code into separate PRs.
@mitodl/devops <https://github.com/orgs/mitodl/teams/devops> do you have an opinion about making the key optional? I actually can't remember why went that route -- I don't expect you know either though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#40 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACRPrUSPJoH6ol8Rfh6bXVYEjqtk54LRks5vRAkkgaJpZM4bQJ3r>.
|
Member
|
I have no opinions on the key, but if needed I can do the digging necessary to form one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on some documentation for our course teams that want to use/create LTI Providers. I couldn't get the Heroku deploy working. I ended up figuring it out, but it required some updates to requirements and the python version. Also the two issues #36 and
#35 (comment)
Can both be resolved by simply quoting out the changes in config.py.
Also, edX is asking that we use lti_consumer as the advanced module. Presumably just to reduce confusion. lti still doesn't break, but it doesn't give you an option to add new lti components unless you have lti_consumer.
Also added a bit of wording in the readme to clarify the client key and client secret.