fix: harden /ddaro:go stage inference fallback (0.6.2)#16
Merged
Conversation
Dogfooding surfaced two too-literal heuristics in the inference path (used only when .ddaro/lifecycle.json is absent): - review-findings detection now matches numbered headings (## 14. Review findings), not just literal ## Review findings -> no false re-review - implementation detection uses merge-base origin/main...HEAD (excluding docs) instead of two-dot tip diff -> immune to a branch merely behind main Also flags LOCK/checkout branch mismatch + far-behind branch and prefers asking over guessing. Normal go-driven flow (lifecycle.json) unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dogfooding 0.6.1 on a real worktree surfaced two too-literal heuristics in
/ddaro:go's inference fallback (the path used only when.ddaro/lifecycle.jsonis absent - adopted / pre-0.6.1 worktrees):## Review findingsheading. A hand-written doc using## 14. Review findings (...)read as not reviewed -> would re-fire the 8-agent review on an already-reviewed doc. Now matches any h2 containing "Review findings" (number/date optional).git diff origin/main(tip vs tip), so a branch merely behind origin/main showed origin's newer files as "changes" -> falsely inferredcheckon a stale branch. Now uses merge-basegit diff --name-only origin/main...HEAD(three dots) + working-tree edits, excludingdocs/**/*.md/.planning/**/.ddaro/**.Also: the conductor now flags a LOCK-vs-checkout branch mismatch / far-behind branch and prefers asking over guessing.
Scope: inference fallback only. The normal
/ddaro:go-driven flow records the stage inlifecycle.jsonand never hits these; the cost-confirm gate already prevented a silent re-review. Markdown + version bump only (no hook/test changes); 82 hook tests still green.