From e6a6abe5f8ee8d3af9f66a44bf1b639175d8b828 Mon Sep 17 00:00:00 2001 From: Bruno Tremblay Date: Tue, 7 Jan 2025 16:18:00 -0500 Subject: [PATCH 1/2] cran-comments --- cran-comments.md | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 5180cf2..1bf28dc 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -3,8 +3,23 @@ Duration: 1m 13.8s ❯ checking installed package size ... NOTE - installed size is 14.8Mb - sub-directories of 1Mb or more: - libs 14.7Mb + installed size is 17.2Mb + sub-directories of 1Mb or more: + libs 16.8Mb + +❯ Files which contain pragma(s) suppressing diagnostics: + 'src/google/api/annotations.pb.h' 'src/google/api/client.pb.h' + 'src/google/api/field_behavior.pb.h' 'src/google/api/http.pb.h' + 'src/google/api/launch_stage.pb.h' 'src/google/api/resource.pb.h' + 'src/google/cloud/bigquery/storage/v1/arrow.pb.h' + 'src/google/cloud/bigquery/storage/v1/avro.pb.h' + 'src/google/cloud/bigquery/storage/v1/protobuf.pb.h' + 'src/google/cloud/bigquery/storage/v1/storage.pb.h' + 'src/google/cloud/bigquery/storage/v1/stream.pb.h' + 'src/google/cloud/bigquery/storage/v1/table.pb.h' + 'src/google/rpc/status.pb.h' -0 errors ✔ | 0 warnings ✔ | 1 note ✖ +0 errors ✔ | 0 warnings ✔ | 2note ✖ + +Tests : [ FAIL 0 | WARN 0 | SKIP 0 | PASS 32 ] +Package checks : https://github.com/meztez/bigrquerystorage/actions/runs/12659190537/job/35277760840 From 14ecb83acda86eb8b9707e1cb7a0b229a4223223 Mon Sep 17 00:00:00 2001 From: Bruno Tremblay Date: Wed, 17 Sep 2025 09:14:48 -0400 Subject: [PATCH 2/2] Fix RANGE conversion. --- .gitignore | 1 + DESCRIPTION | 2 +- NEWS.md | 4 ++++ R/bqs_download.R | 2 +- 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index e61f423..9c0a529 100644 --- a/.gitignore +++ b/.gitignore @@ -18,3 +18,4 @@ src/google/ configure.log autobrew auth.json +.vscode diff --git a/DESCRIPTION b/DESCRIPTION index d7ee5c4..b862a4f 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Package: bigrquerystorage Type: Package Title: An Interface to Google's 'BigQuery Storage' API -Version: 1.2.2 +Version: 1.2.3 Authors@R: c( person("Bruno", "Tremblay", role = c("aut", "cre"), email = "openr@neoxone.com"), person(family = "Google LLC", role = c("cph", "fnd"))) diff --git a/NEWS.md b/NEWS.md index e678af5..fbc0566 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,7 @@ +# bigrquerystorage 1.2.3 + +* Fix RANGE conversion. + # bigrquerystorage 1.2.2 * Fix logging for new version of gRPC. diff --git a/R/bqs_download.R b/R/bqs_download.R index 0caef0c..1d9c3b1 100644 --- a/R/bqs_download.R +++ b/R/bqs_download.R @@ -282,7 +282,7 @@ col_mapply <- function(x, y, tests) { if (inherits(x, "data.frame") && !inherits(x, "tbl_df")) { x <- tibble::tibble(x) } - if (rlang::is_named(x)) { + if (rlang::is_named(x) && length(x) == length(y[["fields"]])) { x[] <- mapply(col_mapply, x, y[["fields"]], MoreArgs = list(tests = tests), SIMPLIFY = FALSE) return(x) } else if (y[["type"]] %in% "RECORD" && y[["mode"]] %in% "REPEATED") {