fix: include rendered templates in helm manifest generation

Signed-off-by: PARTHIV PRATIM SAIKIA <parthivsaikia985@gmail.com>

Author: parthivsaikia

utils/kubernetes/get-manifests.go

@@ -1,23 +1,79 @@
 package kubernetes
 
 import (
+	"fmt"
+	"strings"
+
 	"helm.sh/helm/v3/pkg/chart/loader"
+	"helm.sh/helm/v3/pkg/chartutil"
+	"helm.sh/helm/v3/pkg/engine"
 )
 
+// GetManifestsFromHelm fetches the chart, loads it, and renders templates + CRDs
 func GetManifestsFromHelm(url string) (string, error) {
 	chartLocation, err := fetchHelmChart(url, "")
 	if err != nil {
-		return "", ErrApplyHelmChart(err)
+		return "", ErrApplyHelmChart(fmt.Errorf("failed to fetch helm chart: %w", err))
 	}
 
 	chart, err := loader.Load(chartLocation)
 	if err != nil {
-		return "", ErrApplyHelmChart(err)
+		return "", ErrApplyHelmChart(fmt.Errorf("failed to load chart from %s: %w", chartLocation, err))
+	}
+
+	releaseOptions := chartutil.ReleaseOptions{
+		Name:      "meshery-helm-release",
+		Namespace: "default",
+		Revision:  1,
+		IsInstall: true,
 	}
-	manifests := ""
+
+	caps := chartutil.DefaultCapabilities
+
+	values, err := chartutil.ToRenderValues(chart, chartutil.Values{}, releaseOptions, caps)
+	if err != nil {
+		return "", ErrApplyHelmChart(fmt.Errorf("failed to generate render values: %w", err))
+	}
+
+	renderedFiles, err := engine.Render(chart, values)
+	if err != nil {
+		return "", ErrApplyHelmChart(fmt.Errorf("failed to render chart templates: %w", err))
+	}
+
+	var b strings.Builder
+
+	// Helper to safely append separators
+	appendSeparator := func() {
+		if b.Len() > 0 {
+			b.WriteString("\n---\n")
+		}
+	}
+
+	//  Append CRDs
 	for _, crdobject := range chart.CRDObjects() {
-		manifests += "\n---\n"
-		manifests += string(crdobject.File.Data)
+		appendSeparator()
+		b.Write(crdobject.File.Data)
+	}
+
+	//  Append Rendered Templates
+	for filename, fileContent := range renderedFiles {
+		// Filter out non-manifest files
+		if strings.HasSuffix(filename, "NOTES.txt") {
+			continue
+		}
+		if strings.TrimSpace(fileContent) == "" {
+			continue
+		}
+
+		appendSeparator()
+		b.WriteString(fileContent)
 	}
+
+	manifests := b.String()
+
+	if strings.TrimSpace(manifests) == "" {
+		return "", ErrApplyHelmChart(fmt.Errorf("chart rendered empty manifests"))
+	}
+
 	return manifests, nil
 }