`visualize_plot` modifies global `rcParams` settings

[jonwzheng]

This line:

ChemPlot/chemplot/chemplot.py

Line 447 in 6acf926

sns.set_context("notebook", font_scale=size * 0.15)

modifies the global rcParams plotting style, changing the global font settings.

If using Seaborn/matplotlib elsewhere in one's visualization workflow, this causes an unexpected change.

[JacksonBurns]

@jonwzheng do you know of a way to only do this locally?

[jonwzheng]

i think you could just explicitly set fontsize for every text component (a bit more tedious, and might require some experimentation to get it to look good, but would avoid messing with global settings)

e.g. plt.xlabel("X", fontsize=12)

[JacksonBurns]

Maybe we can just set and then unset it (i.e., save the initial value before we overwrite it, then set it again before returning)?

[jonwzheng]

Yeah that's another option. Looks like can access them with w/:

https://seaborn.pydata.org/generated/seaborn.plotting_context.html#seaborn.plotting_context

and for L446 (setting style to dark):

https://seaborn.pydata.org/generated/seaborn.axes_style.html#seaborn.axes_style

I guess you'd still run into risk of error if the program crashes midway through visualize_plot, but that should be rare.

[JacksonBurns]

@jonwzheng those look promising - let me know if you are willing to contribute a PR!