Skip to content

Consider using more precise response codes #7

@ecleary

Description

@ecleary

model.getQuestions(product_id, count, page, (err, questions) => {
if (err) {
console.log(err);
res.status(400).send(err);
}
res.status(200).send(questions);
});
},
getAnswers: (req, res) => {
let question_id = req.params.question_id;
let count = req.query.count;
let page = req.query.page;
model.getAnswers(question_id, count, page, (err, answers) => {
if (err) {
res.status(400).send();
} else {
res.status(200).send(answers);
}
});
},
addQuestion: (req, res) => {
const question = req.body;
console.log(req.body);
model.addQuestion(question, (err, data) => {
if (err) {
res.status(400).send();
} else {
res.status(200).send('successfully posted question!');
}
});
}

The following applies to lines 12, 24, 35:

The error code 400 indicates that the request from the client was malformed or incorrect in some way. If the error was not caused by a bad request, then a different response code may be more appropriate (404 is often a good choice for GET requests, and 422 or 409 may be a good choice for POST requests).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions