component_id does not support mavlink::common::MavComponent

[patrickelectric]

MavComponent should be allowed to be used with component_id

[hamishwillee]

@patrickelectric What do you mean? There is nothing called MavComponent in common.xml.

If you mean MAV_COMPONENT this is an enum of component ids that have some predefined meaning. In theory you can actually use any component id other than 0 for anything, but in practice this will break code that (incorrectly) relies on the predefined meaning.

EDITED Ah, and now I see that this is a rust mavlink post, and presumably rust-specific. Please ignore me!

[patrickelectric]

Thanks for your input @hamishwillee ! But yes, this is more related to the rust implementation 😄
Sorry for creating this simple issue, but it's better to write it down than forgetting.
The idea is to allow component_id used for the header creation to accept MavComponent enum, right now it only supports unsigned 8bits:
https://docs.rs/mavlink/0.9.0/mavlink/struct.MavHeader.html

But it should also accept MavComponent type:
https://docs.rs/mavlink/0.9.0/mavlink/common/enum.MavComponent.html

Probably I'm going to update the enum to accept an unspecified ID.
MavComponent::UNSPECIFIED(id_that_does_not_exist_in_enum)

[hamishwillee]

No need to be sorry - I think it is excellent to create issues as it is way too easy to lose track of things! And this is definitely a bug.