Passing multiple newlines causes Verfication error in VerifyClearAsync

[OfficialPixelBrush]

Passing a string such as foo\nbar\n\n or foo\n\nbar into ClearSignAsync and then the output of this into VerifyClearAsync returns a false.
This is true for any consecutive newlines.

Example:

string message = "foo\nbar\n\n";

// Generate keys
using (PGP pgp = new PGP())
{
    pgp.GenerateKey(new FileInfo("public.asc"), new FileInfo("private.asc"), "mail@email.com", "insecure_password");
}

// Sign the Message
string privateKey = File.ReadAllText("private.asc");
EncryptionKeys encryptionKeys = new EncryptionKeys(privateKey, password);

PGP pgp2 = new PGP(encryptionKeys);
string signedMessage = await pgp2.ClearSignAsync(message);

// Vertify the Signed Message
string publicKey = File.ReadAllText("public.asc");
EncryptionKeys encryptionKeys = new EncryptionKeys(publicKey);

PGP pgp3 = new PGP(encryptionKeys);
bool isVerified = await pgp3.VerifyClearAsync(signedMessage);

// This will return "false"
Console.WriteLine(isVerified);

Removing the newlines is a potential workaround, albeit a suboptimal one, since some may need these characters.

message = message.Replace("\n", "").Replace("\r", "");

[mattosaurus]

Interesting, thanks for pointing this out, I haven't seen this before.

It's going to be a little while until I get a chance to look into it so I'd suggest just replacing them for now and then I'll push out a fix when I get a chance.

[Bram-van-de-Wetering]

I also ran into this issue when upgrading our software from version 5.8.0 to 6.5.4, and I've managed to trace it back to this commit: eb6a1d7

This change was introduced in version 6.4.1, and if I make a checkout of master and revert those specific changes, the issue seems to be resolved. Can you clarify the intention of those changes?

[mattosaurus]

I think those changes as we were previously adding a newline to the end of the file which was then causing verification issues for messages that didn't have one.

I'll dig back through the code and see if I can remind myself what's going on.

I'll add some tests for different line ending scenarios and see if I can replicate this. If so I'll revert the commit and see if that breaks anything else.

[hempe]

@mattosaurus

Well this commit was the breaking change: eb6a1d75b349f0ce7961bb0f4aa58a2bb12cd39f
So before you added a newline after each line, now you don't

You still add a newline after the first line PgpCore/PGP.VerifySync.cs line 268 and PgpCore/PGP.VerifyAsync.cs line 273
But no longer for the additional lines.

I would suggest this (same for the sync version of course)

var lookAhead = ReadInputLine(lineOut, armoredInputStream);

// Read past message to signature and store message in stream
if (lookAhead != -1 && armoredInputStream.IsClearText())
{
    var line = lineOut.ToArray();
    outStream.Write(line, 0, GetLengthWithoutSeparatorOrTrailingWhitespace(line));
    outStream.Write(lineSep, 0, lineSep.Length);

    while (lookAhead != -1 && armoredInputStream.IsClearText())
    {
        lookAhead = ReadInputLine(lineOut, lookAhead, armoredInputStream);

        line = lineOut.ToArray();
        outStream.Write(line, 0, GetLengthWithoutSeparatorOrTrailingWhitespace(line));
        // Add missing new line
        if (lookAhead != 1)
            outStream.Write(lineSep, 0, lineSep.Length);
    }
}
else if (lookAhead != -1)
{
    var line = lineOut.ToArray();
    outStream.Write(line, 0, GetLengthWithoutSeparatorOrTrailingWhitespace(line));
}

With this I could successfully verify my files with newlines again

[jobvk]

I also ran into this issue when upgrading our software from version 5.8.0 to 6.5.4, and I've managed to trace it back to this commit: eb6a1d7

This change was introduced in version 6.4.1, and if I make a checkout of master and revert those specific changes, the issue seems to be resolved. Can you clarify the intention of those changes?

I also have this issue.
@mattosaurus when will this be fixed?

[mattosaurus]

Apologies for the delay. I've published this fix in 6.5.5 now