Auto-adjust timeout based on actual durations#447
Draft
emaxx-google wants to merge 2 commits into
Draft
Conversation
Automatically reduce the "--timeout" value when actual jobs are executed quicker than its value. Because timings vary hugely in practice, we multiply measured durations by 10x. The auto-adjustment can save a lot of time during late stages of the reduction, when the interestingness test finishes quickly normally, but some unsuccessful reductions may hang (something we observe happening a lot in practice with C/C++ compilers).
emaxx-google
force-pushed
the
dynamic-timeouts
branch
from
6025a4d to
cbdc5d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically reduce the "--timeout" value when actual jobs are executed quicker than its value. Because timings vary hugely in practice, we multiply measured durations by 10x.
The auto-adjustment can save a lot of time during late stages of the reduction, when the interestingness test finishes quickly normally, but some unsuccessful reductions may hang (something we observe happening a lot in practice with C/C++ compilers).
A new flag "--no-auto-adjust-timeout" can be used to suppress the new logic if it misbehaves in some cases.