Bad replay - Oracle agent does not come back toward reference configuration

[marota]

Let's have those two grid2op actions in the best path when playing the oracle:
si grid2op_A= action_1 + action_2
et grid2op_B=action_1+action_2 + action_3

In the case we have grid2op_B at timestep t and grid2op_A at timestept+1, replay will play:

• at t, action_1+action_2 + action_3 so the grid will be in config_t (topo_init + action_1+action_2 + action_3)
• at t+1, action_1+action_2 so the grid will be in (config_t+action_1+action_2)=config_t instead of config_t+1=(topo_init + action_1+action_2). action_3 was not undone ...

We need to test that. topo_vect from graph_node configurations and from replay agent should be the same at each timestep

[marota]

This is connected to this comment as well #24 (comment)

[marota]

For that, take an always changing action path from the graph and make sure to replay it well then
We can use DICT_GAME_PARAMETERS_SIMULATION in replay for easier comparison. The rewards should be the same

[marota]

When we go from action_Oracle_A to action_Oracle_B, delta_action=action3
When we go from action_Oracle_B to action_Oracle_A, delta_action=inverse(action3)=initial_configuration(asset3)

[NMegel]

Done in commit e5eb05c

A memory has been set in the OracleAgent with regard to whether the previous action was legal.

2 tests have been implemented

• "test_cancelling_action" which is a unitary test on a simple 3 timesteps-path
• "test_final_topo_replay" which is more an integration test - we choose a random 100-timestep path with 6 atomic_actions and a max_depth of 4. You were right Antoine it is the best to test a large number of use case. It is easy to verify that our last state has to be the initial state at which we apply the last action! We test that the final topo vect and final line status are comprehensive

[marota]

It seems that if an different action is played at the same substation, a cancelling action would still be created according to

Oracle4Grid/oracle4grid/core/agent/OracleAgent.py

Line 97 in e5eb05c

if previous_atomic_action_repr not in current_atomic_actions_repr:

But it shouldn't, we are just changing the configuration at the same substation

[marota]

In this test

Oracle4Grid/oracle4grid/test/integration_test.py

Line 378 in e5eb05c

def test_final_topo_replay(self):

Many actions might run illegal in this test as the action path is not path taken from the graph:

Oracle4Grid/oracle4grid/test/integration_test.py

Line 404 in e5eb05c

action_path = np.random.choice(actions, max_timestep).tolist()

we should probably check how many there are and if several actions are indeed implemented

[NMegel]

All these actions are legal because the environment is loaded with easy default game rules

With env.action_space._is_legal(action, obs._obs_env), we see that actions are always legal at each timestep. So they are all well done and undone.

[NMegel]

Added a correction in c9afedb because env was generated twice but it doesnt change anything to the tests results

[marota]

All these actions are legal because the environment is loaded with easy default game rules

With env.action_space._is_legal(action, obs._obs_env), we see that actions are always legal at each timestep. So they are all well done and undone.

I see it now, but is not really an integration test anymore as the action path should rather be taken from the graph with DICT_GAME_PARAMETERS_GRAPH. It is a good unit test though

[marota]

It seems that if an different action is played at the same substation, a cancelling action would still be created according to

Oracle4Grid/oracle4grid/core/agent/OracleAgent.py

Line 97 in e5eb05c

if previous_atomic_action_repr not in current_atomic_actions_repr:

But it shouldn't, we are just changing the configuration at the same substation

What about this problem ?

[NMegel]

I am not sure to understand the problem.

Let's suppose we have 2 atomic actions on sub 5. Their representations are sub-5-0 and sub-5-1

For example if we wan't to apply:

• ['sub-5-0','sub-5-1'] at timestep t
• ['sub-5-1'] at timestep t+1

In this situation, OracleAgent will have to undo sub-5-0. This is what it does at line 97 when searching if there are previous atomic actions that don't belong to current actions