Skip to content

Readability: Duplicated ResampleQuality type definition across modules #25

@m96-chan

Description

@m96-chan

Summary

The ResampleQuality type alias is defined in multiple places, violating the DRY principle.

Locations

  1. src/proctap/core.py:27
  2. src/proctap/backends/init.py:18
  3. src/proctap/backends/converter.py:20

Problem

Each module defines its own copy:

ResampleQuality = Literal['best', 'medium', 'fast']

This means:

  • Changes must be made in 3 places
  • Risk of inconsistent updates
  • Harder to maintain

Suggested Fix

Define ResampleQuality in a single location (e.g., backends/base.py or a dedicated types.py) and import from there.

Labels

readability, refactor

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions