Summary
The ResampleQuality type alias is defined in multiple places, violating the DRY principle.
Locations
- src/proctap/core.py:27
- src/proctap/backends/init.py:18
- src/proctap/backends/converter.py:20
Problem
Each module defines its own copy:
ResampleQuality = Literal['best', 'medium', 'fast']
This means:
- Changes must be made in 3 places
- Risk of inconsistent updates
- Harder to maintain
Suggested Fix
Define ResampleQuality in a single location (e.g., backends/base.py or a dedicated types.py) and import from there.
Labels
readability, refactor
Summary
The ResampleQuality type alias is defined in multiple places, violating the DRY principle.
Locations
Problem
Each module defines its own copy:
This means:
Suggested Fix
Define ResampleQuality in a single location (e.g., backends/base.py or a dedicated types.py) and import from there.
Labels
readability, refactor