Skip to content

Not enough contrast. #4

@rweichler

Description

@rweichler

This didn't seem to be a problem in the commits around February, but now there is a pretty huge problem with the contrast between the text colors and the background color.

Here are some examples. Title/controls are PrimaryTextColor, album/artist are SecondaryTextColor:
    

Also note specifically in Dr. Dre's 2001 and Immortal Technique's Peruvian Cocaine, BackgroundColor should be #000000 and #FFFFFF respectively, but it seems like you just took the average color of the entire image instead of just sampling the edges. It's kind of hard to tell, but the BackgroundColor of 2001 is actually a very dark green.

Also note how the first image is basically completely black, and the text colors don't default to something like white.

Also, these are just extraneous circumstances, most of the colors that get picked are REALLY good. Props.

I'll try and see if I can do anything about this on my end, but I thought I should let you know :)

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions