Reporting of individual attributes

[Wollwolke]

Hey, I am working on enabling reporting of individual attributes as well as optional reporting of attributes immediately on setting. Therefore I have moved the reporting feature to ZigBeeAttributes.

See my branch here: individual_reporting

The functionality is implemented, but I still have problems with the following random crashes:

StackTrace

[14:05:08][D][esp-idf:000]: E (Zigbee stack assertion failed common/zb_error_indication.c:81
[14:05:08]
[14:05:08]abort() was called at PC 0x420bbd0d on core 0
[14:05:08]Core  0 register dump:
[14:05:08]MEPC    : 0x4080248c  RA      : 0x4080c74e  SP      : 0x4082fe20  GP      : 0x408132a4
WARNING Decoded 0x4080248c: panic_abort at C:\Users\Wollwolke\.platformio\packages\framework-espidf\components\esp_system/panic.c:463
WARNING Decoded 0x4080248c: panic_abort at C:\Users\Wollwolke\.platformio\packages\framework-espidf\components\esp_system/panic.c:463
[14:05:09]TP      : 0x4082ffa0  T0      : 0x37363534  T1      : 0x7271706f  T2      : 0x33323130
[14:05:09]S0/FP   : 0x4082fe5c  S1      : 0x4082fe5c  A0      : 0x4082fe5c  A1      : 0x4082fe3e
[14:05:09]A2      : 0x00000000  A3      : 0x4082fe89  A4      : 0x00000001  A5      : 0x4081b000
[14:05:09]A6      : 0x00000000  A7      : 0x76757473  S2      : 0x4082fe40  S3      : 0x40818174
[14:05:09]S4      : 0x00000001  S5      : 0x00000000  S6      : 0x00000000  S7      : 0x00000000
[14:05:09]S8      : 0x00000000  S9      : 0x00000000  S10     : 0x00000000  S11     : 0x00000000
[14:05:09]T3      : 0x6e6d6c6b  T4      : 0x6a696867  T5      : 0x66656463  T6      : 0x62613938
[14:05:09]MSTATUS : 0x00001881  MTVEC   : 0x40800001  MCAUSE  : 0x00000007  MTVAL   : 0x00000000
[14:05:09]MHARTID : 0x00000000

The crash is related to the way I'm updating the reporting info in the setup function. It doesn't happen if esp_zb_zcl_update_reporting_info() is not called.

I have already experimented with the zigbee lock and the setup priority, but I can't figure out what the root cause is. Maybe someone here with a better understanding of the zigbee stack has an idea.

[luar123]

I would keep esp_zb_zcl_update_reporting_info in the zigbee component and just move the report action to the attributes.

as well as optional reporting of attributes immediately on setting

Proposal: add a force option to the report parameter.

And please try to apply esphome coding standards (e.q. always use this-> for class attributes) and activate the pre-commit hook.

[Wollwolke]

I reworked it and didn't move the initial reporting setup (which "fixed" the issues with the crashes). Since I want to keep the ability to report all attributes at once and report only specific ones, I need to set a reference to the attribute in the set_report function. To limit the parameters I suggest to create the esp_zb_zcl_reporting_info_t on the attribute side but store it in the zigbee component.
I also removed the automatic reporting from the set_attr function, I can live with calling the report function after setting a value (so no need for an extra force parameter).

What do you think about this approach?
Just out of curiosity: Why did you choose to use a deque to store the reporting_infos?

[luar123]

Looks good to me. Could you create a PR once #34 is merged?

Just out of curiosity: Why did you choose to use a deque to store the reporting_infos?

I guess I thought it is faster/uses less memory than a list and better for extending compared to a vector. In this specific case it probably doesn't matter at all, though.
Anyway, I don't have much C++ experience, so feel free to suggest changes.

[Wollwolke]

Sure, I'll do. What's missing in #34 to merge it?

[luar123]

It looks fine, but I want to test it and check in detail.