DEPENDENCY ISSUE

[hhh2210]

#36

Problem

1. Missing datasets dependency in requirements.txt causes runtime error
2. Import statements inside functions (bad practice)
3. Missing proxy configuration documentation

Details

• from datasets import load_dataset is placed inside gen_worker() function
• Users need to manually add datasets to requirements.txt
• HTTP proxy setup required but not documented

Suggested fixes

1. Add datasets to requirements.txt
2. Move import statements to file top
3. Document proxy requirements in README

[lsdefine]

the ``datasets'' is only used for a simple testing with gsm8k. For real usage, the user should use their own data, so ``datasets'' is not the requirements. I will add some descriptions in README. Thank you~ Larry Hao ***@***.***> 于2025年8月5日周二 10:47写道：

…

*hhh2210* created an issue (lsdefine/simple_GRPO#47) <#47> #36 <#36> as the issue 36 shows, clearly the requirements.txt is not fully tested Please considering fix this issue — Reply to this email directly, view it on GitHub <#47>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZYVG57YKIUQXPQ5BWFVFT3MALLFAVCNFSM6AAAAACDDTWLIWVHI2DSMVQWIX3LMV43ASLTON2WKOZTGI4TCMZVGQZDIMQ> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[hhh2210]

Thanks for your reply,
The issue here is that when new users want to do simple testing with your repo, the training gets stuck at "waiting for batch". At this point, it's difficult to troubleshoot that it's caused by not having the datasets library installed.