Skip to content

CMake packaging: missing install() rules and modern CMake policy compatibility #21

@chenrui333

Description

@chenrui333

Hi! Thanks for ls-hpack.

While packaging ls-hpack for Homebrew, I noticed two CMake usability issues:

  1. CMakeLists.txt has no install() rules
  • We can build libls-hpack.a, but cmake --install installs nothing.
  • Packagers currently need manual install steps for headers + library.
  1. Modern CMake compatibility
  • With current CMake, configure fails unless we pass:
    -DCMAKE_POLICY_VERSION_MINIMUM=3.5
  • The project currently has:
    cmake_minimum_required(VERSION 2.8)

Would you consider:

  • adding install rules, e.g.
    • install(TARGETS ls-hpack ...)
    • install(FILES lshpack.h lsxpack_header.h DESTINATION include)
  • and bumping/modernizing CMake minimum/policy handling?

Happy to test a patch.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions