Hi! Thanks for ls-hpack.
While packaging ls-hpack for Homebrew, I noticed two CMake usability issues:
CMakeLists.txt has no install() rules
- We can build
libls-hpack.a, but cmake --install installs nothing.
- Packagers currently need manual install steps for headers + library.
- Modern CMake compatibility
- With current CMake, configure fails unless we pass:
-DCMAKE_POLICY_VERSION_MINIMUM=3.5
- The project currently has:
cmake_minimum_required(VERSION 2.8)
Would you consider:
- adding install rules, e.g.
install(TARGETS ls-hpack ...)
install(FILES lshpack.h lsxpack_header.h DESTINATION include)
- and bumping/modernizing CMake minimum/policy handling?
Happy to test a patch.
Hi! Thanks for ls-hpack.
While packaging
ls-hpackfor Homebrew, I noticed two CMake usability issues:CMakeLists.txthas noinstall()ruleslibls-hpack.a, butcmake --installinstalls nothing.-DCMAKE_POLICY_VERSION_MINIMUM=3.5cmake_minimum_required(VERSION 2.8)Would you consider:
install(TARGETS ls-hpack ...)install(FILES lshpack.h lsxpack_header.h DESTINATION include)Happy to test a patch.