fix: show prev/next buttons for single multi-page TIF file#294
Merged
Conversation
Fix visibility condition and async loading timing issue: - QML: use hasPreviousImage/hasNextImage instead of imageCount > 1 - C++: connect infoChanged to checkSwitchEnable for async frame data 修复单文件多页TIF图片工具栏上一张/下一张按钮不显示的问题, 包含QML可见性条件修复和C++异步加载时序修复。 Log: 修复多页TIF工具栏按钮不显示 PMS: BUG-323847 Influence: 修复后打开单张多页TIF图片时,工具栏上一张/下一张按钮正常显示, 多文件场景和单张普通图片场景不受影响。
3f5124c to
287307c
Compare
Guard against null model and empty state in checkSwitchEnable() to handle cases where async infoChanged fires after model is cleared. 增加checkSwitchEnable的防御性检查,防止异步回调时模型已清空 导致的越界访问风险。 Log: 增加checkSwitchEnable防御性检查 PMS: BUG-323847 Influence: 提升异步回调场景下的健壮性,防止模型清空后的越界访问。
deepin pr auto review你好!我是CodeGeeX。我已仔细审查了你提供的Git Diff。本次修改主要涉及图片查看器中缩略图列表显示逻辑的优化、切换按钮状态检查的防抖处理、边界条件的安全加固以及多帧图片(如动图)判断逻辑的修复。 整体来看,代码质量有所提升,特别是引入防抖机制和移除 1. 语法与逻辑
2. 代码质量
3. 代码性能
4. 代码安全
总结与改进建议本次代码变更质量很高,修复了潜在的越界/空指针崩溃问题,并通过防抖机制优化了高频事件下的性能表现。代码风格统一,逻辑严谨。 唯一建议修改的地方:关于版权年份 |
lzwind
approved these changes
May 18, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wyu71 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix visibility condition and async loading timing issue:
修复单文件多页TIF图片工具栏上一张/下一张按钮不显示的问题,
包含QML可见性条件修复和C++异步加载时序修复。
Log: 修复多页TIF工具栏按钮不显示
PMS: BUG-323847
Influence: 修复后打开单张多页TIF图片时,工具栏上一张/下一张按钮正常显示,
多文件场景和单张普通图片场景不受影响。