Skip to content

chore: update changelog to 2.0.38#1568

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-2.0.38
Apr 23, 2026
Merged

chore: update changelog to 2.0.38#1568
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
mhduiy:dev-changelog-2.0.38

Conversation

@mhduiy
Copy link
Copy Markdown
Contributor

@mhduiy mhduiy commented Apr 23, 2026

更新说明

自动更新 changelog 到版本 2.0.38

变更内容

  • 更新 debian/changelog

版本信息

  • 新版本: 2.0.38
  • 目标分支: master

Summary by Sourcery

Documentation:

  • Refresh debian/changelog entries to document version 2.0.38.

update changelog to 2.0.38

Log: update changelog to 2.0.38
@github-actions
Copy link
Copy Markdown

TAG Bot

TAG: 2.0.38
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743
Copy link
Copy Markdown
Contributor

/forcemerge

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented Apr 23, 2026

This pr force merged! (status: blocked)

@deepin-bot deepin-bot Bot merged commit 38e7f90 into linuxdeepin:master Apr 23, 2026
8 of 12 checks passed
@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

这段 debian/changelog 的 diff 记录了 dde-shell 项目从版本 2.0.37 升级到 2.0.38 的变更内容。从格式和内容上看,它遵循了 Debian 的 changelog 规范。以下是从语法逻辑代码质量代码安全改进建议四个方面的详细审查:

1. 语法逻辑与规范

  • 格式规范性

    • 该 diff 严格遵循了 Debian 控制文件的格式要求:软件名 (版本) 发行版; 紧急程度
    • 每一个变更条目前缀使用了 *,并正确使用了 fix:(修复)、feat:(新功能)、refactor:(重构)等约定俗成的标签,这有助于快速理解变更的性质。
    • 维护者信息和日期时间格式符合标准。
  • 逻辑一致性

    • 潜在冲突:在变更列表中存在以下两条看似矛盾的记录:
      • Revert "refactor: move dockiteminfo to shared frame library"
      • refactor: move dockiteminfo to shared frame library
    • 分析:通常在 Git 提交历史中,如果先 Revert(回滚)了某个提交,然后又重新应用了该提交,说明中间可能发生了测试失败、代码冲突解决或者是分支合并策略的调整。
    • 结论:在 changelog 中同时出现这两条记录虽然逻辑上可能反映真实的开发过程(即:改了 -> 发现有问题回滚 -> 修复后再次提交),但会让阅读者感到困惑。建议确认是否最终版本中确实包含该重构代码。如果最终包含,建议只保留最后一条有效的变更记录,或者合并说明为 "refactor: re-apply dockiteminfo move to shared frame library"。

2. 代码质量

  • 变更粒度

    • 本次发布包含 13 个条目,涉及 UI 修复、逻辑重构、新功能添加等多个方面。对于一个次版本号更新(2.0.37 -> 2.0.38),这个变更量是合理的。
    • 涉及的修复点(如托盘子菜单位置、任务栏布局、剪贴板数据过滤)都是用户可见或影响体验的关键点,说明开发团队关注细节。
  • 重构与架构

    • move bubble overlay logic to QML delegateadd dock library and refactor dock plugin management 表明项目正在向更好的模块化和声明式 UI(QML)方向演进,这有助于提升代码的可维护性。
    • centralize relative time formatting logic 是很好的代码质量改进,消除了重复逻辑,降低了维护成本。

3. 代码安全

  • 数据过滤

    • fix: filter clipboard data for plugin Wayland clients:这是一个重要的安全相关修复。在 Wayland 协议下,安全隔离更为严格,正确过滤剪贴板数据可以防止潜在的信息泄露或恶意数据注入。建议在代码审查中重点检查过滤逻辑的完整性。
  • DBus 交互

    • fix: filter unsupported dock applets in DBus proxy:通过 DBus 代理过滤不支持的插件,有助于防止因调用不存在的插件接口而导致的服务崩溃(DoS 风险)或异常行为,增强了系统的稳定性。

4. 改进建议

  1. 清理 Changelog 历史

    • 如前所述,建议移除 Revert "..." 这一条目,除非该回滚操作在最终发布的代码中是生效的(即最终版本确实没有包含该重构)。如果最终版本包含该重构,保留 Revert 记录会造成文档与事实不符,应予以删除。
  2. 长文本换行

    • 虽然目前 diff 中的换行处理是正确的(如 fix: separate touchscreen and mouse...),但在编写 changelog 时,建议尽量保持每条记录在一行内,或者确保换行后的缩进清晰,以便于自动化工具解析和阅读。
  3. 版本号与日期

    • diff 中的日期显示为 2026 年(Thu, 23 Apr 2026)。这显然是未来的日期,可能是系统时间错误或笔误。
    • 严重性:高。错误的构建时间可能会影响包管理系统(如 APT)的依赖判断或升级逻辑。
    • 建议:请务必将年份修正为当前正确的年份(例如 2023 或 2024)。
  4. 关联 Issue/Bug ID

    • 建议在每个 fix:feat: 条目后附带对应的 Bug 跟踪系统的 ID(例如 Closes: #12345(Bug: #101))。这样可以建立代码变更与问题追踪之间的联系,方便后续的回溯和质量分析。

总结

这段 diff 格式规范,涵盖了重要的功能修复和架构优化。主要需要关注的是修正日期中的年份错误,以及理清关于 dockiteminfo 重构的重复/回滚记录,以确保变更日志的准确性和清晰度。安全方面的修改(剪贴板过滤)是积极的信号。

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented Apr 23, 2026

TAG Bot

Tag created successfully

📋 Tag Details
  • Tag Name: 2.0.38
  • Tag SHA: f6d1542f4ee13d73a39410be2cab0542b16779aa
  • Commit SHA: b9addb1f16de357dab683f3e7cf12fcd8a5fe85d
  • Tag Message:
    Release dde-shell 2.0.38
    
    
  • Tagger:
    • Name: mhduiy
  • Distribution: unstable

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 23, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Debian changelog to bump the package version to 2.0.38 on the master branch.

File-Level Changes

Change Details Files
Bump package version metadata in the Debian changelog to 2.0.38.
  • Update the top changelog entry to reflect new version 2.0.38.
  • Adjust associated metadata in the changelog entry (e.g., date, maintainer, or description) if applicable to this version bump.
debian/changelog

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants