Skip to content

chore: missing some translations for notification#1088

Merged
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
18202781743:master
Apr 10, 2025
Merged

chore: missing some translations for notification#1088
deepin-bot[bot] merged 1 commit into
linuxdeepin:masterfrom
18202781743:master

Conversation

@18202781743
Copy link
Copy Markdown
Contributor

@18202781743 18202781743 commented Apr 10, 2025

as title.

pms: BUG-289337

Summary by Sourcery

Update translations for notification center with missing translations and time-related improvements

Enhancements:

  • Add specific translation for '1 hour ago' to improve time display accuracy

Chores:

  • Update XML encoding and DOCTYPE for translation files
  • Remove deprecated 'Notification Setting' translations

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 10, 2025

Reviewer's Guide by Sourcery

This pull request adds missing translations, updates existing translations for accuracy and grammar, and syncs translation files with source code for the notification center in multiple languages. It also introduces a specific translation for '1 hour ago'.

Updated class diagram for AppNotifyItem

classDiagram
    class AppNotifyItem {
        - QDateTime time
        - int elapsedSeconds
        + void updateTime()
        + QString getFormattedTime()

    }
    note for AppNotifyItem "Updates to updateTime() to include specific translation for '1 hour ago'"
Loading

File-Level Changes

Change Details Files
Added missing translations for the notification center in multiple languages.
  • Added translation for '1 hour ago'.
  • Updated translations for time-related strings to be more accurate and grammatically correct.
  • Removed the 'Notification Setting' translation in NotifyHeader.qml.
  • Updated file encoding to utf-8.
panels/notification/center/translations/org.deepin.ds.notificationcenter_ru.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_az.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_ca.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_es.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_fi.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_fr.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_hu.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_ja.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_pl.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_pt_BR.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_uk.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_zh_CN.ts
Sync translation files with source code.
  • Update the location of the string 'Clear All' in GroupNotify.qml.
  • Update the location of the string 'Notification Center' in NotifyHeader.qml.
  • Update the location of the string 'Just now' in notifyitem.cpp.
  • Update the location of the string '%1 minutes ago' in notifyitem.cpp.
  • Update the location of the string '%1 hours ago' in notifyitem.cpp.
  • Update the location of the string 'Yesterday' in notifyitem.cpp.
panels/notification/center/translations/org.deepin.ds.notificationcenter.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_bo.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_it.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_ko.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_nb_NO.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_zh_HK.ts
panels/notification/center/translations/org.deepin.ds.notificationcenter_zh_TW.ts
Added a specific translation for '1 hour ago'.
  • Added a specific translation for '1 hour ago' in notifyitem.cpp to improve accuracy.
panels/notification/center/notifyitem.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It looks like you've added a translation for '1 hour ago', but haven't translated it in all the files.
  • The location of some strings has changed, which might require translators to re-translate some strings.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, yixinshark

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743
Copy link
Copy Markdown
Contributor Author

/forcemerge

@deepin-bot
Copy link
Copy Markdown

deepin-bot Bot commented Apr 10, 2025

This pr force merged! (status: blocked)

@deepin-bot deepin-bot Bot merged commit 5763d34 into linuxdeepin:master Apr 10, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants