Conversation
This reverts commit e7a9802.
1. Removed [Install] sections from both deepin-login-sound.service and deepin-shutdown-sound.service 2. These services are meant to be triggered manually rather than being enabled/started at boot 3. The WantedBy directives were unnecessary since these are one-shot services 4. Improves system startup performance by not loading unnecessary services fix: 从 systemd 声音服务中移除 Install 部分 1. 从 deepin-login-sound.service 和 deepin-shutdown-sound.service 中移除 了 [Install] 部分 2. 这些服务设计为手动触发而非在启动时自动启用/运行 3. WantedBy 指令对于一次性服务来说是不必要的 4. 通过不加载不必要的服务来提高系统启动性能
Reviewer's GuideRemoves the [Install] sections from the deepin-login-sound and deepin-shutdown-sound systemd unit files and adjusts Debian packaging so they are no longer enabled at boot, ensuring these one-shot services are only invoked manually and reducing startup overhead. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review代码审查意见:
综上所述,代码审查意见是积极的,但需要确保移除 |
fly602
approved these changes
Jul 3, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fly602, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove Install sections from systemd sound services
deepin-shutdown-sound.service
enabled/started at boot
services
services
fix: 从 systemd 声音服务中移除 Install 部分
了 [Install] 部分
Summary by Sourcery
Remove installation sections from deepin-login-sound.service and deepin-shutdown-sound.service so they aren’t enabled at boot, reflecting their one-shot, manually triggered nature and improving system startup performance.
Bug Fixes:
Enhancements: